Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2870293002: Introduce luci-go components version metric. (Closed)

Created:
3 years, 7 months ago by Vadim Sh.
Modified:
3 years, 7 months ago
Reviewers:
dnj, iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Introduce luci-go components version metric. A large chunk of luci-go library is used as a common GAE runtime for many LUCI and Chrome Infra apps. It becomes hard to track what apps are outdated and need to be redeployed. This CL makes each individual GAE process report 'luci/components/version' metric with semantic version of the luci-go GAE library, so we can precisely see what is currently running in production. The code is a bit more general to eventually allow reporting versions of other optional components (like Tumble and pRPC server runtime). R=iannucci@chromium.org, dnj@chromium.org BUG= Review-Url: https://codereview.chromium.org/2870293002 Committed: https://github.com/luci/luci-go/commit/842c196920ca287e07fdc52378a812b306870776

Patch Set 1 #

Patch Set 2 : luci-go/appengine is actually not imported by anything >_< #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
A appengine/gaemiddleware/version.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
M appengine/tsmon/standardmetrics.go View 2 chunks +2 lines, -0 lines 0 comments Download
A common/tsmon/versions/versions.go View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vadim Sh.
PTAL
3 years, 7 months ago (2017-05-10 01:05:08 UTC) #1
Vadim Sh.
Note that in theory we could extract this information for GAE app version string, but: ...
3 years, 7 months ago (2017-05-10 01:11:20 UTC) #2
iannucci
lgtm! Step 1, get data :)
3 years, 7 months ago (2017-05-10 01:13:38 UTC) #3
Vadim Sh.
finally deployed for real and confirmed it works: http://shortn/_6Jh0HidBCp
3 years, 7 months ago (2017-05-24 00:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870293002/20001
3 years, 7 months ago (2017-05-24 00:58:00 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 01:06:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/842c196920ca287e07fdc52378a812b306870776

Powered by Google App Engine
This is Rietveld 408576698