Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2870263004: Add an about:flag to enable client-side LoFi (Closed)

Created:
3 years, 7 months ago by RyanSturm
Modified:
3 years, 7 months ago
Reviewers:
Steven Holte, sclittle
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an about:flag to enable client-side LoFi This allows users to turn client-side LoFi on android. BUG=720920 Review-Url: https://codereview.chromium.org/2870263004 Cr-Commit-Position: refs/heads/master@{#471030} Committed: https://chromium.googlesource.com/chromium/src/+/faf9214134a3262cf35553521f71fa60207602ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/previews/core/previews_experiments.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/previews/core/previews_experiments_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M components/previews/core/previews_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/previews/core/previews_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
RyanSturm
holte: PTAL @ enums.xml sclittle: PTAL
3 years, 7 months ago (2017-05-10 22:15:39 UTC) #6
sclittle
LGTM! Thanks for doing this!
3 years, 7 months ago (2017-05-10 22:22:26 UTC) #7
Steven Holte
You shouldn't need OWNERS review for enums.xml changes, but lgtm
3 years, 7 months ago (2017-05-11 17:42:43 UTC) #8
RyanSturm
On 2017/05/11 17:42:43, Steven Holte wrote: > You shouldn't need OWNERS review for enums.xml changes, ...
3 years, 7 months ago (2017-05-11 17:55:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870263004/1
3 years, 7 months ago (2017-05-11 18:01:00 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 19:07:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/faf9214134a3262cf35553521f71...

Powered by Google App Engine
This is Rietveld 408576698