Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2870253002:
[LayoutNG] Remove space_builder_ member from block algorithm. (Closed)
|
Created:
3 years, 7 months ago by ikilpatrick Modified:
3 years, 7 months ago CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Remove space_builder_ member from block algorithm.
Just a small cleanup.
BUG=635619
Review-Url: https://codereview.chromium.org/2870253002
Cr-Commit-Position: refs/heads/master@{#471151}
Committed: https://chromium.googlesource.com/chromium/src/+/da4d35823f06ecc77f46d29263e15320c1df17ed
Patch Set 1 #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
ikilpatrick@chromium.org changed reviewers: + glebl@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by ikilpatrick@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ikilpatrick@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ikilpatrick@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494540721163500, "parent_rev":
"2ae33ffef0abd60c2fb050dbbadafae3345c568a", "commit_rev":
"da4d35823f06ecc77f46d29263e15320c1df17ed"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Remove space_builder_ member from block algorithm. Just a small cleanup. BUG=635619 ========== to ========== [LayoutNG] Remove space_builder_ member from block algorithm. Just a small cleanup. BUG=635619 Review-Url: https://codereview.chromium.org/2870253002 Cr-Commit-Position: refs/heads/master@{#471151} Committed: https://chromium.googlesource.com/chromium/src/+/da4d35823f06ecc77f46d29263e1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/da4d35823f06ecc77f46d29263e1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
