Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2870213003:
Remove /dev/dri/card0 from sandbox whitelist (Closed)
|
Created:
3 years, 7 months ago by dnicoara Modified:
3 years, 7 months ago Reviewers:
Jorge Lucangeli Obes CC:
chromium-reviews, jam, darin-cc_chromium.org, jln+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove /dev/dri/card0 from sandbox whitelist
In ChromeOS the graphics cards are opened in the browser process and
IPC-ed to the GPU.
BUG=482610
TEST=Ran on link, and daisy and verified Chrome starts up
Review-Url: https://codereview.chromium.org/2870213003
Cr-Commit-Position: refs/heads/master@{#472200}
Committed: https://chromium.googlesource.com/chromium/src/+/262cced60f936c9de24eaa94b6a96f2e1dcce7c0
Patch Set 1 #Patch Set 2 : updated description #
Total comments: 2
Patch Set 3 : comment #Messages
Total messages: 22 (16 generated)
The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dnicoara@chromium.org changed reviewers: + jorgelo@chromium.org
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jorgelo@google.com changed reviewers: + jorgelo@google.com
Thanks for doing this! https://codereview.chromium.org/2870213003/diff/20001/content/common/sandbox_... File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (right): https://codereview.chromium.org/2870213003/diff/20001/content/common/sandbox_... content/common/sandbox_linux/bpf_gpu_policy_linux.cc:358: // For multi-card DRI setups. NOTE: /dev/dri/card0 was already added above. Remove NOTE, and change comment since this will cover single-card setups too.
Description was changed from ========== Remove /dev/dri/card0 from sandbox whitelist In ChromeOS the graphics cards are opened in the browser process and IPC-ed to the GPU. BUG=482610 TEST=Ran on link and verified Chrome starts up ========== to ========== Remove /dev/dri/card0 from sandbox whitelist In ChromeOS the graphics cards are opened in the browser process and IPC-ed to the GPU. BUG=482610 TEST=Ran on link and verified Chrome starts up ==========
jorgelo@chromium.org changed reviewers: - jorgelo@google.com
Description was changed from ========== Remove /dev/dri/card0 from sandbox whitelist In ChromeOS the graphics cards are opened in the browser process and IPC-ed to the GPU. BUG=482610 TEST=Ran on link and verified Chrome starts up ========== to ========== Remove /dev/dri/card0 from sandbox whitelist In ChromeOS the graphics cards are opened in the browser process and IPC-ed to the GPU. BUG=482610 TEST=Ran on link, and daisy and verified Chrome starts up ==========
https://codereview.chromium.org/2870213003/diff/20001/content/common/sandbox_... File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (right): https://codereview.chromium.org/2870213003/diff/20001/content/common/sandbox_... content/common/sandbox_linux/bpf_gpu_policy_linux.cc:358: // For multi-card DRI setups. NOTE: /dev/dri/card0 was already added above. On 2017/05/16 14:40:06, Jorge Lucangeli Obes (Google) wrote: > Remove NOTE, and change comment since this will cover single-card setups too. Done. Ahh, I can't believe I didn't spot it. Thank you!
lgtm
The CQ bit was checked by dnicoara@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494954279231570,
"parent_rev": "8a886995ef55f7c165f50a27a309761c7432bc2c", "commit_rev":
"262cced60f936c9de24eaa94b6a96f2e1dcce7c0"}
Message was sent while issue was closed.
Description was changed from ========== Remove /dev/dri/card0 from sandbox whitelist In ChromeOS the graphics cards are opened in the browser process and IPC-ed to the GPU. BUG=482610 TEST=Ran on link, and daisy and verified Chrome starts up ========== to ========== Remove /dev/dri/card0 from sandbox whitelist In ChromeOS the graphics cards are opened in the browser process and IPC-ed to the GPU. BUG=482610 TEST=Ran on link, and daisy and verified Chrome starts up Review-Url: https://codereview.chromium.org/2870213003 Cr-Commit-Position: refs/heads/master@{#472200} Committed: https://chromium.googlesource.com/chromium/src/+/262cced60f936c9de24eaa94b6a9... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/262cced60f936c9de24eaa94b6a9... |
