Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: third_party/WebKit/Source/platform/wtf/allocator/Partitions.h

Issue 2870213002: Update the PartitionAlloc documentation. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/wtf/allocator/Partitions.h
diff --git a/third_party/WebKit/Source/platform/wtf/allocator/Partitions.h b/third_party/WebKit/Source/platform/wtf/allocator/Partitions.h
index 8c842fc85a0032a61e756c283933ceb6dccb145c..67e87bb4615d158905444d7b7b6fb8bbdea56237 100644
--- a/third_party/WebKit/Source/platform/wtf/allocator/Partitions.h
+++ b/third_party/WebKit/Source/platform/wtf/allocator/Partitions.h
@@ -130,19 +130,7 @@ class WTF_EXPORT Partitions {
static base::subtle::SpinLock initialization_lock_;
static bool initialized_;
- // We have the following four partitions.
- // - LayoutObject partition: A partition to allocate LayoutObjects.
- // We prepare a dedicated partition for LayoutObjects because they
- // are likely to be a source of use-after-frees. Another reason
- // is for performance: As LayoutObjects are guaranteed to only be used
- // by the main thread, we can bypass acquiring a lock. Also we can
- // improve memory locality by putting LayoutObjects together.
- // - ArrayBuffer partition: A partition to allocate array buffers.
- // - Buffer partition: A partition to allocate other buffers that have
- // a strong risk where the length and/or the contents are exploited from
- // user scripts. Vectors, HashTables and Strings are allocated in the
- // buffer partition.
- // - Fast malloc partition: A partition to allocate all other objects.
+ // See Allocator.md for a description of these partitions.
static base::PartitionAllocatorGeneric fast_malloc_allocator_;
static base::PartitionAllocatorGeneric array_buffer_allocator_;
static base::PartitionAllocatorGeneric buffer_allocator_;

Powered by Google App Engine
This is Rietveld 408576698