Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2870193002:
Clean up expired verdicts at shutdown (Closed)
|
Created:
3 years, 7 months ago by Jialiu Lin Modified:
3 years, 7 months ago Reviewers:
lpz CC:
chromium-reviews, grt+watch_chromium.org, timvolodine, vakh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean up expired verdicts when PasswordProtectionService is being destructed (typically, that's during browser shutdown).
BUG=719002
Review-Url: https://codereview.chromium.org/2870193002
Cr-Commit-Position: refs/heads/master@{#471000}
Committed: https://chromium.googlesource.com/chromium/src/+/51e211250511fe271acddb55983d50f48bca0386
Patch Set 1 #Patch Set 2 : refine tests #Patch Set 3 : nit #
Total comments: 2
Patch Set 4 : nit #Patch Set 5 : resolve container-overflow #
Messages
Total messages: 31 (26 generated)
The CQ bit was checked by jialiul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jialiul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by jialiul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jialiul@chromium.org changed reviewers: + lpz@chromium.org
Hi lpz@, This CL removes all the expired cached verdicts when PasswordProtectionService is shutting down. Could you take a look? Thanks!
Description was changed from ========== Clean up expired verdicts at browser shutdown BUG=719002 ========== to ========== Clean up expired verdicts when PasswordProtectionService is being destructed (typically, that's during browser shutdown). BUG=719002 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
lgtm https://codereview.chromium.org/2870193002/diff/40001/components/safe_browsin... File components/safe_browsing/password_protection/password_protection_service.cc (right): https://codereview.chromium.org/2870193002/diff/40001/components/safe_browsin... components/safe_browsing/password_protection/password_protection_service.cc:227: it.key(), &verdict_entry)); nit: align?
The CQ bit was checked by jialiul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jialiul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for your quick review! It seems "git cl format" has a very special aesthetic sense. :-P Latest patch also resolved a container-overflow problem caught by asan fuzzer. https://codereview.chromium.org/2870193002/diff/40001/components/safe_browsin... File components/safe_browsing/password_protection/password_protection_service.cc (right): https://codereview.chromium.org/2870193002/diff/40001/components/safe_browsin... components/safe_browsing/password_protection/password_protection_service.cc:227: it.key(), &verdict_entry)); On 2017/05/10 at 14:03:54, lpz wrote: > nit: align? Acknowledged. "git cl format" insists this is the best alignment. >.<
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by jialiul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lpz@chromium.org Link to the patchset: https://codereview.chromium.org/2870193002/#ps80001 (title: "resolve container-overflow")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494523681290730,
"parent_rev": "42e64aa07b0c14272ec351517ef75acc9a946a38", "commit_rev":
"51e211250511fe271acddb55983d50f48bca0386"}
Message was sent while issue was closed.
Description was changed from ========== Clean up expired verdicts when PasswordProtectionService is being destructed (typically, that's during browser shutdown). BUG=719002 ========== to ========== Clean up expired verdicts when PasswordProtectionService is being destructed (typically, that's during browser shutdown). BUG=719002 Review-Url: https://codereview.chromium.org/2870193002 Cr-Commit-Position: refs/heads/master@{#471000} Committed: https://chromium.googlesource.com/chromium/src/+/51e211250511fe271acddb55983d... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/51e211250511fe271acddb55983d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
