Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2870113002: m_foo -> foo_ in SettingsMacros, fix DEBUG_TEXT_AUTOSIZING_ON_DESKTOP build. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

m_foo -> foo_ in SettingsMacros, and fix DEBUG_TEXT_AUTOSIZING_ON_DESKTOP build. No behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2870113002 Cr-Commit-Position: refs/heads/master@{#470457} Committed: https://chromium.googlesource.com/chromium/src/+/cb282bdd726c1dc16ec415b2267d08d2ce3248e6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.cpp View 1 chunk +2 lines, -2 lines 2 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
Nico
https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp File third_party/WebKit/Source/core/frame/Settings.cpp (right): https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp#newcode66 third_party/WebKit/Source/core/frame/Settings.cpp:66: text_autosizing_enabled_(true) Given that this hasn't been building for a ...
3 years, 7 months ago (2017-05-09 15:15:30 UTC) #4
pdr.
LGTM https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp File third_party/WebKit/Source/core/frame/Settings.cpp (right): https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp#newcode66 third_party/WebKit/Source/core/frame/Settings.cpp:66: text_autosizing_enabled_(true) On 2017/05/09 at 15:15:30, Nico wrote: > ...
3 years, 7 months ago (2017-05-09 22:29:03 UTC) #7
Nico
On 2017/05/09 22:29:03, pdr. wrote: > LGTM > > https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp > File third_party/WebKit/Source/core/frame/Settings.cpp (right): > ...
3 years, 7 months ago (2017-05-09 22:51:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870113002/1
3 years, 7 months ago (2017-05-09 22:52:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:55:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870113002/1
3 years, 7 months ago (2017-05-10 00:59:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 03:04:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870113002/1
3 years, 7 months ago (2017-05-10 03:25:22 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 04:46:30 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb282bdd726c1dc16ec415b2267d...

Powered by Google App Engine
This is Rietveld 408576698