m_foo -> foo_ in SettingsMacros, fix DEBUG_TEXT_AUTOSIZING_ON_DESKTOP build.

m_foo -> foo_ in SettingsMacros, and fix DEBUG_TEXT_AUTOSIZING_ON_DESKTOP build.

No behavior change.

BUG=675877
Review-Url: https://codereview.chromium.org/2870113002
Cr-Commit-Position: refs/heads/master@{#470457}
Committed: https://chromium.googlesource.com/chromium/src/+/cb282bdd726c1dc16ec415b2267d08d2ce3248e6

[Nico, 2017-05-09 15:14:41]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 15:15:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-09 15:15:29]

thakis@chromium.org changed reviewers:
+ pdr@chromium.org

[Nico, 2017-05-09 15:15:30]

https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Settings.cpp (right):

https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Settings.cpp:66:
text_autosizing_enabled_(true)
Given that this hasn't been building for a few weeks, maybe we can just remove
this?

[commit-bot: I haz the power, 2017-05-09 18:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:06:15]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-05-09 22:29:03]

LGTM

https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Settings.cpp (right):

https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Settings.cpp:66:
text_autosizing_enabled_(true)
On 2017/05/09 at 15:15:30, Nico wrote:
> Given that this hasn't been building for a few weeks, maybe we can just remove
this?

sure, this isn't all that useful anymore because we can use the inspector to get
autosizing on desktop.

LGTM to remove if you want to (or leave if you don't have time to).

[Nico, 2017-05-09 22:51:03]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-05-09 22:51:47]

On 2017/05/09 22:29:03, pdr. wrote:
> LGTM
> 
>
https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/Settings.cpp (right):
> 
>
https://codereview.chromium.org/2870113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/Settings.cpp:66:
> text_autosizing_enabled_(true)
> On 2017/05/09 at 15:15:30, Nico wrote:
> > Given that this hasn't been building for a few weeks, maybe we can just
remove
> this?
> 
> sure, this isn't all that useful anymore because we can use the inspector to
get
> autosizing on desktop.
> 
> LGTM to remove if you want to (or leave if you don't have time to).

Thanks! I'll send a separate cl for removal, to not forfeit the good cq spot
this cl has.

[commit-bot: I haz the power, 2017-05-09 22:52:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:55:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Nico, 2017-05-10 00:57:54]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:59:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:04:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Nico, 2017-05-10 03:24:13]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:25:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:46:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494386653231210, "parent_rev":
"ad8d381bee80bc2ae99792f198f8c954d60a7c03", "commit_rev":
"cb282bdd726c1dc16ec415b2267d08d2ce3248e6"}

[commit-bot: I haz the power, 2017-05-10 04:46:29]

Description was changed from

==========
m_foo -> foo_ in SettingsMacros, and fix DEBUG_TEXT_AUTOSIZING_ON_DESKTOP build.

No behavior change.

BUG=675877
==========

to

==========
m_foo -> foo_ in SettingsMacros, and fix DEBUG_TEXT_AUTOSIZING_ON_DESKTOP build.

No behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2870113002
Cr-Commit-Position: refs/heads/master@{#470457}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb282bdd726c1dc16ec415b2267d...
==========

[commit-bot: I haz the power, 2017-05-10 04:46:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb282bdd726c1dc16ec415b2267d...