Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2870093002:
Test Emoji from v5 emoji-data.txt (Closed)
|
Created:
3 years, 7 months ago by drott Modified:
3 years, 7 months ago CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionTest Emoji from v5 emoji-data.txt
The test will be disabled until the ICU upgrade to v59 is merged.
BUG=719963
Review-Url: https://codereview.chromium.org/2870093002
Cr-Commit-Position: refs/heads/master@{#470519}
Committed: https://chromium.googlesource.com/chromium/src/+/80db61a2f1eaa7555d0a6bfa6e432b52f9530592
Patch Set 1 #
Total comments: 2
Patch Set 2 : Comment explaining the test #Messages
Total messages: 20 (11 generated)
drott@chromium.org changed reviewers: + behdad@chromium.org, eae@chromium.org, jshin@chromium.org
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2870093002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp (right): https://codereview.chromium.org/2870093002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp:228: TEST_F(SymbolsIteratorTest, DISABLED_Emoji5AdditionsExceptFlags) { Wouldn't it be better to test each emoji separately?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2870093002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp (right): https://codereview.chromium.org/2870093002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp:228: TEST_F(SymbolsIteratorTest, DISABLED_Emoji5AdditionsExceptFlags) { On 2017/05/09 at 15:18:16, eae wrote: > Wouldn't it be better to test each emoji separately? My intention here is mainly to verify that none of the v5 additions get split up. What happens before ICU 59 is that new emoji sequences and new single emoji are not detected as emoji type text and sequences get split up in the middle so that shaping cannot form the right glyph from the emoji font. That's why I thought merging them all in one compact test is sufficient to ensure an unbroken emoji-type sequence. Wdyt?
OK, Please add a comment explaining the test. LGTM
The CQ bit was checked by drott@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2870093002/#ps20001 (title: "Comment explaining the test")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm Lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494404919865280,
"parent_rev": "2b53772d6855f3bc314bff3cbc4ee9f4a7bedb87", "commit_rev":
"80db61a2f1eaa7555d0a6bfa6e432b52f9530592"}
Message was sent while issue was closed.
Description was changed from ========== Test Emoji from v5 emoji-data.txt The test will be disabled until the ICU upgrade to v59 is merged. BUG=719963 ========== to ========== Test Emoji from v5 emoji-data.txt The test will be disabled until the ICU upgrade to v59 is merged. BUG=719963 Review-Url: https://codereview.chromium.org/2870093002 Cr-Commit-Position: refs/heads/master@{#470519} Committed: https://chromium.googlesource.com/chromium/src/+/80db61a2f1eaa7555d0a6bfa6e43... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/80db61a2f1eaa7555d0a6bfa6e43... |
