Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 287009: Move WebDevToolsAgent{Delegate} into the WebKit API.... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org
Visibility:
Public.

Description

Move WebDevToolsAgent{Delegate} into the WebKit API. Moves corresponding WebView and WebViewDelegate methods too. This uses the term "Frontend" for what was previously known as "Client" in the devtools interfaces. This is to avoid awkward "ClientClient" naming. Frontend was Pavel Feldman's suggested renaming. In a follow up patch, I will be renaming WebDevToolsClient{Delegate} to WebDevToolsFrontend{Client}. R=dglazkov BUG=24597 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29369

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -340 lines) Patch
M chrome/renderer/devtools_agent.h View 1 2 2 chunks +16 lines, -12 lines 0 comments Download
M chrome/renderer/devtools_agent.cc View 8 chunks +19 lines, -16 lines 0 comments Download
M chrome/renderer/devtools_agent_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/devtools_agent_filter.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/external_host_bindings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/notification_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 5 chunks +6 lines, -5 lines 0 comments Download
A + webkit/api/public/WebDevToolsAgent.h View 1 chunk +57 lines, -45 lines 0 comments Download
A + webkit/api/public/WebDevToolsAgentClient.h View 1 chunk +48 lines, -24 lines 0 comments Download
M webkit/api/public/WebFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/api/public/WebView.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/api/public/WebViewClient.h View 3 chunks +6 lines, -0 lines 0 comments Download
M webkit/glue/devtools/debugger_agent_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/devtools/debugger_agent_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/devtools/debugger_agent_manager.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/glue/editor_client_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/mimetype_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
D webkit/glue/webdevtoolsagent.h View 1 chunk +0 lines, -62 lines 0 comments Download
D webkit/glue/webdevtoolsagent_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.h View 5 chunks +18 lines, -18 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.cc View 12 chunks +40 lines, -39 lines 0 comments Download
M webkit/glue/webview.h View 2 chunks +0 lines, -17 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 chunk +0 lines, -31 lines 0 comments Download
M webkit/glue/webview_impl.h View 4 chunks +1 line, -6 lines 0 comments Download
M webkit/glue/webview_impl.cc View 6 chunks +10 lines, -15 lines 0 comments Download
M webkit/tools/test_shell/mac/test_shell_webview.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 2 months ago (2009-10-16 20:51:42 UTC) #1
dglazkov
11 years, 2 months ago (2009-10-16 21:22:23 UTC) #2
I think you need an extra "WebFrame.h" include in mimetype_unittest.cc, and then
LGTM.

http://codereview.chromium.org/287009/diff/1/20
File chrome/renderer/devtools_agent.h (right):

http://codereview.chromium.org/287009/diff/1/20#newcode38
Line 38: // WebDevToolsAgentDelegate implementation
WebDevToolsAgentClient?

http://codereview.chromium.org/287009/diff/1/6
File webkit/api/public/WebViewClient.h (right):

http://codereview.chromium.org/287009/diff/1/6#newcode250
Line 250: 
sorry about that :)

http://codereview.chromium.org/287009/diff/1/19
File webkit/glue/webview_delegate.h (left):

http://codereview.chromium.org/287009/diff/1/19#oldcode63
Line 63: 
Awesomeness!!!!

http://codereview.chromium.org/287009/diff/3001/4010
File webkit/glue/webdevtoolsagent_impl.cc (right):

http://codereview.chromium.org/287009/diff/3001/4010#newcode270
Line 270: 
Nice elimination here!

Powered by Google App Engine
This is Rietveld 408576698