Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: chrome/renderer/devtools_agent_filter.h

Issue 287009: Move WebDevToolsAgent{Delegate} into the WebKit API.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/devtools_agent.cc ('k') | chrome/renderer/devtools_agent_filter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_ 5 #ifndef CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_
6 #define CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_ 6 #define CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
11 #include "ipc/ipc_channel_proxy.h" 11 #include "ipc/ipc_channel_proxy.h"
12 12
13 class WebDevToolsAgent;
14
15 // DevToolsAgentFilter is registered as an IPC filter in order to be able to 13 // DevToolsAgentFilter is registered as an IPC filter in order to be able to
16 // dispatch messages while on the IO thread. The reason for that is that while 14 // dispatch messages while on the IO thread. The reason for that is that while
17 // debugging, Render thread is being held by the v8 and hence no messages 15 // debugging, Render thread is being held by the v8 and hence no messages
18 // are being dispatched there. While holding the thread in a tight loop, 16 // are being dispatched there. While holding the thread in a tight loop,
19 // v8 provides thread-safe Api for controlling debugger. In our case v8's Api 17 // v8 provides thread-safe Api for controlling debugger. In our case v8's Api
20 // is being used from this communication agent on the IO thread. 18 // is being used from this communication agent on the IO thread.
21 class DevToolsAgentFilter : public IPC::ChannelProxy::MessageFilter { 19 class DevToolsAgentFilter : public IPC::ChannelProxy::MessageFilter {
22 public: 20 public:
23 // There is a single instance of this class instantiated by the RenderThread. 21 // There is a single instance of this class instantiated by the RenderThread.
24 DevToolsAgentFilter(); 22 DevToolsAgentFilter();
25 virtual ~DevToolsAgentFilter(); 23 virtual ~DevToolsAgentFilter();
26 24
27 private: 25 private:
28 // IPC::ChannelProxy::MessageFilter override. Called on IO thread. 26 // IPC::ChannelProxy::MessageFilter override. Called on IO thread.
29 virtual bool OnMessageReceived(const IPC::Message& message); 27 virtual bool OnMessageReceived(const IPC::Message& message);
30 28
31 static void DispatchMessageLoop(); 29 static void DispatchMessageLoop();
32 30
33 // OnDebuggerCommand will be executed in the IO thread so that we can 31 // OnDebuggerCommand will be executed in the IO thread so that we can
34 // handle debug messages even when v8 is stopped. 32 // handle debug messages even when v8 is stopped.
35 void OnDebuggerCommand(const std::string& command); 33 void OnDebuggerCommand(const std::string& command);
36 34
37 int current_routing_id_; 35 int current_routing_id_;
38 36
39 DISALLOW_COPY_AND_ASSIGN(DevToolsAgentFilter); 37 DISALLOW_COPY_AND_ASSIGN(DevToolsAgentFilter);
40 }; 38 };
41 39
42 #endif // CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_ 40 #endif // CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/devtools_agent.cc ('k') | chrome/renderer/devtools_agent_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698