Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Issue 2870033002: Mark PageLoad UKM as singular. (Closed)

Created:
3 years, 7 months ago by Steven Holte
Modified:
3 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark PageLoad UKM as singular. This indicates that "PageLoad" event conceptually only happens once per source. BUG= Review-Url: https://codereview.chromium.org/2870033002 Cr-Commit-Position: refs/heads/master@{#471009} Committed: https://chromium.googlesource.com/chromium/src/+/3b2a27989ad0d93dcefd88c7f63fcb0e893b1c2c

Patch Set 1 #

Patch Set 2 : Mark PageLoad as singular #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/metrics/ukm/model.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/ukm/ukm.xml View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Steven Holte
3 years, 7 months ago (2017-05-08 23:51:44 UTC) #2
Steven Holte
3 years, 7 months ago (2017-05-08 23:53:00 UTC) #4
rkaplow
Can you give more details on how we'll use this? I'm not against it, but ...
3 years, 7 months ago (2017-05-10 14:40:14 UTC) #5
Steven Holte
On 2017/05/10 14:40:14, rkaplow wrote: > Can you give more details on how we'll use ...
3 years, 7 months ago (2017-05-10 16:10:28 UTC) #6
rkaplow
lgtm
3 years, 7 months ago (2017-05-11 15:23:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870033002/20001
3 years, 7 months ago (2017-05-11 17:58:02 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 18:10:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b2a27989ad0d93dcefd88c7f63f...

Powered by Google App Engine
This is Rietveld 408576698