Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2870023003: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::RevealSelection (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::RevealSelection This patch prunes a call site of the deprecated function. The change is safe because layout is already clean there, updated right after entering FrameSelection::RevealSelection. BUG=698633 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2870023003 Cr-Commit-Position: refs/heads/master@{#470266} Committed: https://chromium.googlesource.com/chromium/src/+/551e4143b7c88d46312b4923c383687bfb9f525a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
Xiaocheng
PTAL.
3 years, 7 months ago (2017-05-09 03:47:22 UTC) #8
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-09 08:28:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870023003/1
3 years, 7 months ago (2017-05-09 08:29:13 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 08:33:19 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/551e4143b7c88d46312b4923c383...

Powered by Google App Engine
This is Rietveld 408576698