cros: Create virtual device name only when two audio nodes sharing the same device index

cros: Create virtual device name only when two audio nodes sharing the same device index

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may not share the same device index, meanwhile, headphone and line-out may share the same device index. This cl is to fix this by creating virtual device name only when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index, otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index, otherwise show "Headphone" and "Line Out" separately.

TBR=dgreid@chromium.org
BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2869933002
Cr-Commit-Position: refs/heads/master@{#471020}
Committed: https://chromium.googlesource.com/chromium/src/+/69b678b8b026433cb8fe4948ab5b723f0bef189c

[Qiang(Joe) Xu, 2017-05-08 20:16:01]

Description was changed from

==========
cros: Create virtual device name only when there are actually two audio nodes
sharing the same device index

BUG=718220
==========

to

==========
cros: Create virtual device name only when there are actually two audio nodes
sharing the same device index

BUG=718220
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Qiang(Joe) Xu, 2017-05-08 20:17:17]

Description was changed from

==========
cros: Create virtual device name only when there are actually two audio nodes
sharing the same device index

BUG=718220
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

BUG=718220
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Qiang(Joe) Xu, 2017-05-08 20:24:39]

Description was changed from

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

BUG=718220
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

BUG=718220
TEST=tested on kevin and veyron_minnie, works properly.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Qiang(Joe) Xu, 2017-05-08 20:24:39]

warx@chromium.org changed reviewers:
+ dgreid@chromium.org, tommi@chromium.org

[Qiang(Joe) Xu, 2017-05-08 20:25:52]

Description was changed from

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

BUG=718220
TEST=tested on kevin and veyron_minnie, works properly.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on
https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Qiang(Joe) Xu, 2017-05-08 20:27:36]

Description was changed from

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on
https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in
mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on
https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Qiang(Joe) Xu, 2017-05-08 20:29:22]

+dgreid, changes are based on the discussion from issue 718220.

+tommi, for owner review.

Thanks!

[Qiang(Joe) Xu, 2017-05-10 17:57:53]

On 2017/05/08 20:29:22, Qiang(Joe) Xu wrote:
> +dgreid, changes are based on the discussion from issue 718220.
> 
> +tommi, for owner review.
> 
> Thanks!

Friendly ping. Note this also needs to be merged to M-59. So let us get it
earlier.

[tommi (sloooow) - chröme, 2017-05-10 17:59:42]

lgtm. (sorry for the delay, I thought had replied)

[Qiang(Joe) Xu, 2017-05-11 16:56:34]

Description was changed from

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in
mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on
https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in
mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

TBR=dgreid@chromium.org
BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on
https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Qiang(Joe) Xu, 2017-05-11 16:56:49]

warx@chromium.org changed reviewers:
- dgreid@chromium.org

[Qiang(Joe) Xu, 2017-05-11 16:58:01]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:58:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 18:41:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494521881094290, "parent_rev":
"fb2492ce3f4bf8d9e151f3759b42be6aca6155c4", "commit_rev":
"69b678b8b026433cb8fe4948ab5b723f0bef189c"}

[commit-bot: I haz the power, 2017-05-11 18:41:18]

Description was changed from

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in
mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

TBR=dgreid@chromium.org
BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on
https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
cros: Create virtual device name only when two audio nodes sharing the same
device index

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in
mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may
not share the same device index, meanwhile, headphone and line-out may share the
same device index. This cl is to fix this by creating virtual device name only
when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise
show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index,
otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index,
otherwise show "Headphone" and "Line Out" separately.

TBR=dgreid@chromium.org
BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on
https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2869933002
Cr-Commit-Position: refs/heads/master@{#471020}
Committed:
https://chromium.googlesource.com/chromium/src/+/69b678b8b026433cb8fe4948ab5b...
==========

[commit-bot: I haz the power, 2017-05-11 18:41:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69b678b8b026433cb8fe4948ab5b...