Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Issue 2869903002: [ios clean] Dismisses ToolsMenu on Layout changes. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
index bdfcad661eced3e263d3fcc6dd2f08f31d3be217..cdfa2c170d99777e5fa442cf3451bd4d4f766c8f 100644
--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
@@ -85,6 +85,12 @@
UIEdgeInsetsMake(CGRectGetMaxY(self.toolbar.frame), 0, 0, 0);
}
+- (void)viewWillLayoutSubviews {
+ // We need to dismiss the ToolsMenu everytime the Toolbar position changes
+ // (e.g. Size changes, rotation changes, etc.)
marq (ping after 24h) 2017/05/09 12:13:26 This is probably fine, but note that the condition
sczs 2017/05/10 02:25:46 Yes, you're right! I was stating what are we tryin
+ [self.dispatcher closeToolsMenu];
+}
+
#pragma mark - SettingsActions
- (void)showSettings:(id)sender {

Powered by Google App Engine
This is Rietveld 408576698