[ios clean] Dismisses ToolsMenu on Layout changes.

ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h"
 
 #include "base/mac/foundation_util.h"
 #import "ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.h"
 #import "ios/clean/chrome/browser/ui/actions/settings_actions.h"
 #import "ios/clean/chrome/browser/ui/actions/tab_grid_actions.h"
@@ skipping 67 matching lines @@
                    cr_frameForTabGridNewTabButtonInRect:self.view.bounds]];
   [self.view addSubview:self.floatingNewTabButton];
 }
 
 - (void)viewDidLayoutSubviews {
   [super viewDidLayoutSubviews];
   self.tabs.contentInset =
       UIEdgeInsetsMake(CGRectGetMaxY(self.toolbar.frame), 0, 0, 0);
 }
 
+- (void)viewWillLayoutSubviews {
+  // We need to dismiss the ToolsMenu everytime the Toolbar position changes
+  // (e.g. Size changes, rotation changes, etc.)

[marq (ping after 24h), 2017/05/09 12:13:26]

This is probably fine, but note that the conditions you list are not the
conditions for what triggers a layout. If any change is made to the view
hierarchy -- resizing a subview, for example -- that may also cause this to
trigger. 

[sczs, 2017/05/10 02:25:46]

Yes, you're right! I was stating what are we trying to achieve, or why are we
doing this. My own comment was showing me that something wasn't right. I've now
updated this.

+  [self.dispatcher closeToolsMenu];
+}
+
 #pragma mark - SettingsActions
 
 - (void)showSettings:(id)sender {
   [self.dispatcher showSettings];
 }
 
 #pragma mark - ToolsMenuActions
 
 - (void)showToolsMenu:(id)sender {
   [self.dispatcher showToolsMenu];
@@ skipping 39 matching lines @@
       UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
   [self.tabs addSubview:overlayView];
   self.noTabsOverlay = overlayView;
 }
 
 - (void)removeNoTabsOverlay {
   [self.noTabsOverlay removeFromSuperview];
 }
 
 @end