|
|
Created:
3 years, 7 months ago by please use gerrit instead Modified:
3 years, 7 months ago CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), gogerald+paymentswatch_chromium.org, haraken, mahmadi+paymentswatch_chromium.org, qsr+mojo_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionWarn web developer on missing favicon for PaymentRequest UI.
Before this patch, a missing favicon would result in a blank space on
PaymentRequest UI on Android and no indication to the web developer that
something went wrong.
This patch adds a Mojo method PaymentRequestClient.WarnNoFavicon(),
which is invoked by the browser and implemented in the renderer. The
browser invokes the method when it finds no favicon and thus leaves a
blank space on UI. The renderer implementation prints a warning in
DevTools:
"Favicon not found for PaymentRequest UI. User may not recognize the
website."
After this patch, a missing favicon on a page that's using
PaymentRequest on Android results in a DevTools warning for the web
developer.
BUG=710002
Review-Url: https://codereview.chromium.org/2869893002
Cr-Commit-Position: refs/heads/master@{#472954}
Committed: https://chromium.googlesource.com/chromium/src/+/4b040be30ba61d2589511f2225a99d1dafeb46da
Patch Set 1 #
Total comments: 2
Patch Set 2 : Ganggui's comment #
Messages
Total messages: 42 (25 generated)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
rouslan@chromium.org changed reviewers: + gogerald@chromium.org, mattgaunt@google.com, mek@chromium.org, palmer@chromium.org
Marijn, ptal WebKit. Ganggui, ptal Java. Chris, ptal mojom. Matt, ptal the warning message phrasing.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Warn web developer on missing favicon for PaymentRequest UI. Before this patch, a missing favicon would result in a blank space on PaymentRequest UI on Android and no indication to the web developer that something went wrong. This patch adds a Mojo method PaymentRequestClient.WarnNoFavicon(), which is invoked by the browser and implemented in the renderer. The browser invokes the method when it finds no favicon and thus leaves a blank space on UI. The renderer implementation prints a warning in DevTools: "Favicon not found for PaymentRequest UI. User may not recognize the website." After this patch, a missing favicon on a page that's using PaymentRequest on Android results in a DevTools warning for the web developer. BUG=710002 ========== to ========== Warn web developer on missing favicon for PaymentRequest UI. Before this patch, a missing favicon would result in a blank space on PaymentRequest UI on Android and no indication to the web developer that something went wrong. This patch adds a Mojo method PaymentRequestClient.WarnNoFavicon(), which is invoked by the browser and implemented in the renderer. The browser invokes the method when it finds no favicon and thus leaves a blank space on UI. The renderer implementation prints a warning in DevTools: "Favicon not found for PaymentRequest UI. User may not recognize the website." After this patch, a missing favicon on a page that's using PaymentRequest on Android results in a DevTools warning for the web developer. BUG=710002 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm w/o comment, https://codereview.chromium.org/2869893002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/2869893002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:530: if (bitmap == null) mClient.warnNoFavicon(); if(bitmap == null && mClient != null) mClient.warnNoFavicon(); This is inside an asynchronous call back,
https://codereview.chromium.org/2869893002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/2869893002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:530: if (bitmap == null) mClient.warnNoFavicon(); On 2017/05/08 22:13:56, gogerald1 wrote: > if(bitmap == null && mClient != null) mClient.warnNoFavicon(); > > This is inside an asynchronous call back, Done.
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
rouslan@chromium.org changed reviewers: - mattgaunt@google.com
The CQ bit was checked by rouslan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org, gogerald@chromium.org Link to the patchset: https://codereview.chromium.org/2869893002/#ps20001 (title: "Ganggui's comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495129641951670, "parent_rev": "6f8167514ca5a2fc2235cd4694f60598cd49bbf6", "commit_rev": "4b040be30ba61d2589511f2225a99d1dafeb46da"}
Message was sent while issue was closed.
Description was changed from ========== Warn web developer on missing favicon for PaymentRequest UI. Before this patch, a missing favicon would result in a blank space on PaymentRequest UI on Android and no indication to the web developer that something went wrong. This patch adds a Mojo method PaymentRequestClient.WarnNoFavicon(), which is invoked by the browser and implemented in the renderer. The browser invokes the method when it finds no favicon and thus leaves a blank space on UI. The renderer implementation prints a warning in DevTools: "Favicon not found for PaymentRequest UI. User may not recognize the website." After this patch, a missing favicon on a page that's using PaymentRequest on Android results in a DevTools warning for the web developer. BUG=710002 ========== to ========== Warn web developer on missing favicon for PaymentRequest UI. Before this patch, a missing favicon would result in a blank space on PaymentRequest UI on Android and no indication to the web developer that something went wrong. This patch adds a Mojo method PaymentRequestClient.WarnNoFavicon(), which is invoked by the browser and implemented in the renderer. The browser invokes the method when it finds no favicon and thus leaves a blank space on UI. The renderer implementation prints a warning in DevTools: "Favicon not found for PaymentRequest UI. User may not recognize the website." After this patch, a missing favicon on a page that's using PaymentRequest on Android results in a DevTools warning for the web developer. BUG=710002 Review-Url: https://codereview.chromium.org/2869893002 Cr-Commit-Position: refs/heads/master@{#472954} Committed: https://chromium.googlesource.com/chromium/src/+/4b040be30ba61d2589511f2225a9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4b040be30ba61d2589511f2225a9... |