[Media Controls] Instrumentation test for video rotate-to-fullscreen

[Media Controls] Instrumentation test for video rotate-to-fullscreen

Adds Android instrumentation test for the functionality added in
https://codereview.chromium.org/2830713003
913ee5fe4cfcc42ebc568965169258bc37fb0237 master@{#468137}

BUG=713225
Review-Url: https://codereview.chromium.org/2869843002
Cr-Commit-Position: refs/heads/master@{#470305}
Committed: https://chromium.googlesource.com/chromium/src/+/7ac3b5f054f1300ff52423497e865f6caa3d1356

[johnme, 2017-05-08 16:21:53]

johnme@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-05-08 16:31:49]

lgtm

https://codereview.chromium.org/2869843002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java
(right):

https://codereview.chromium.org/2869843002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java:97:
}
Can you add a TODO that says that this could be
"@Restriction(RESTRICTION_TYPE_PHONE)" when the restriction moves outside of
//chrome?

(I'm pretty sure I've opened a bug about this but I can't find it.)

[johnme, 2017-05-08 16:43:21]

Addressed review comment - thanks :)

https://codereview.chromium.org/2869843002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java
(right):

https://codereview.chromium.org/2869843002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java:97:
}
On 2017/05/08 16:31:49, mlamouri - OOO until May 8th wrote:
> Can you add a TODO that says that this could be
> "@Restriction(RESTRICTION_TYPE_PHONE)" when the restriction moves outside of
> //chrome?
> 
> (I'm pretty sure I've opened a bug about this but I can't find it.)

Done. Couldn't find it either, so I filed crbug.com/719560. Also left TODOs in
VideoFullscreenOrientationLockTest.

[johnme, 2017-05-08 16:43:26]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-05-08 16:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2869843002/#ps20001
(title: "Add RESTRICTION_TYPE_PHONE TODO")

[johnme, 2017-05-08 16:43:32]

The CQ bit was unchecked by johnme@chromium.org

[johnme, 2017-05-08 16:44:24]

johnme@chromium.org changed reviewers:
+ dtrainor@chromium.org

[johnme, 2017-05-08 16:44:25]

dtrainor@chromium.org: Please give owners approval - thanks!

[David Trainor- moved to gerrit, 2017-05-09 05:45:04]

lgtm

[johnme, 2017-05-09 12:02:59]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-05-09 12:02:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2869843002/#ps40001
(title: "crbug s/719560/673917/")

[commit-bot: I haz the power, 2017-05-09 12:03:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 13:24:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494331379005630,
"parent_rev": "21be5ad542a27e814f797c3cbe774d1d606fe0b3", "commit_rev":
"7ac3b5f054f1300ff52423497e865f6caa3d1356"}

[commit-bot: I haz the power, 2017-05-09 13:25:02]

Description was changed from

==========
[Media Controls] Instrumentation test for video rotate-to-fullscreen

Adds Android instrumentation test for the functionality added in
https://codereview.chromium.org/2830713003
913ee5fe4cfcc42ebc568965169258bc37fb0237 master@{#468137}

BUG=713225
==========

to

==========
[Media Controls] Instrumentation test for video rotate-to-fullscreen

Adds Android instrumentation test for the functionality added in
https://codereview.chromium.org/2830713003
913ee5fe4cfcc42ebc568965169258bc37fb0237 master@{#468137}

BUG=713225

Review-Url: https://codereview.chromium.org/2869843002
Cr-Commit-Position: refs/heads/master@{#470305}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ac3b5f054f1300ff52423497e86...
==========

[commit-bot: I haz the power, 2017-05-09 13:25:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7ac3b5f054f1300ff52423497e86...