Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869793003:
Remove the interface tests for Push Messaging (Closed)
|
Created:
3 years, 7 months ago by Peter Beverloo Modified:
3 years, 7 months ago Reviewers:
johnme CC:
chromium-reviews, blink-reviews, Peter Beverloo, johnme+watch_chromium.org, harkness+watch_chromium.org, awdf+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove the interface tests for Push Messaging
These are redundant with the global interface listings we have in the
project. No need to test it twice. Behaviour of the PushEvent interface
is covered by pushevent-extendable-event.html and pushmessagedata.html.
BUG=
Review-Url: https://codereview.chromium.org/2869793003
Cr-Commit-Position: refs/heads/master@{#472807}
Committed: https://chromium.googlesource.com/chromium/src/+/9fe1e8ac7f58e8167bb26ed1b32657c492e9bc35
Patch Set 1 #Patch Set 2 : rebase #
Depends on Patchset: Messages
Total messages: 25 (13 generated)
peter@chromium.org changed reviewers: + johnme@chromium.org
+johnme
lgtm
The CQ bit was checked by peter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org Link to the patchset: https://codereview.chromium.org/2869793003/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by peter@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by peter@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by peter@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by peter@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495112711861120,
"parent_rev": "098c35c20b6879046acd7b2922751dc199c31bc6", "commit_rev":
"9fe1e8ac7f58e8167bb26ed1b32657c492e9bc35"}
Message was sent while issue was closed.
Description was changed from ========== Remove the interface tests for Push Messaging These are redundant with the global interface listings we have in the project. No need to test it twice. Behaviour of the PushEvent interface is covered by pushevent-extendable-event.html and pushmessagedata.html. BUG= ========== to ========== Remove the interface tests for Push Messaging These are redundant with the global interface listings we have in the project. No need to test it twice. Behaviour of the PushEvent interface is covered by pushevent-extendable-event.html and pushmessagedata.html. BUG= Review-Url: https://codereview.chromium.org/2869793003 Cr-Commit-Position: refs/heads/master@{#472807} Committed: https://chromium.googlesource.com/chromium/src/+/9fe1e8ac7f58e8167bb26ed1b326... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9fe1e8ac7f58e8167bb26ed1b326... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
