Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2869733006: Revert "Revert "fix #27256, track type bounds for generic functions"" (Closed)

Created:
3 years, 7 months ago by Jennifer Messerly
Modified:
3 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "fix #27256, track type bounds for generic functions"" This reverts commit 3a23e604e2a15f707809d748696e043acfe7a274. The problem was unrelated to the CL; it appears to be a dart:async break of package:async. In the meantime we have turned on --unsafe-force-compile to DDC's shapshotting step Committed: https://github.com/dart-lang/sdk/commit/811a9eed1da4f84193df95ccf5d5f352a5e10a4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -392 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +40 lines, -49 lines 0 comments Download
M pkg/dev_compiler/test/browser/runtime_tests.js View 25 chunks +223 lines, -223 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js View 3 chunks +12 lines, -12 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/async_helper.js View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/closure.js View 2 chunks +20 lines, -20 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/destructuring.js View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/es6_modules.js View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/map_keys.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/node_modules.js View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/script.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/varargs.js View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 9 chunks +179 lines, -49 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language_strong/generic_function_bounds_test.dart View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
TBR
3 years, 7 months ago (2017-05-09 21:19:34 UTC) #2
Jennifer Messerly
On 2017/05/09 21:19:34, Jennifer Messerly wrote: > TBR There are no changes to this CL ...
3 years, 7 months ago (2017-05-09 21:20:16 UTC) #3
Jennifer Messerly
3 years, 7 months ago (2017-05-09 21:20:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
811a9eed1da4f84193df95ccf5d5f352a5e10a4c.

Powered by Google App Engine
This is Rietveld 408576698