pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 2869733006: Revert "Revert "fix #27256, track type bounds for generic functions""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2869733006: Revert "Revert "fix #27256, track type bounds for generic functions"" (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index 8e8a2cd130b78152f2ee78e6406ea2a16a3590eb..b2fd6c586fbbfa009403195d6980172b0e652856 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -246,9 +246,7 @@ _checkAndCall(f, ftype, obj, typeArgs, args, name) => JS(

let formalCount = $ftype.formalCount;

if ($typeArgs == null) {

- // TODO(jmesserly): this should use instantiate to bounds logic.

- // See https://github.com/dart-lang/sdk/issues/27256

- $typeArgs = Array(formalCount).fill($dynamic);

+ $typeArgs = $ftype.instantiateDefaultBounds();

} else if ($typeArgs.length != formalCount) {

// TODO(jmesserly): is this the right error?

$throwStrongModeError(

@@ -256,7 +254,6 @@ _checkAndCall(f, ftype, obj, typeArgs, args, name) => JS(

$typeName($ftype) + ', got <' + $typeArgs + '> expected ' +

formalCount + '.');

}

- // Instantiate the function type.

$ftype = $ftype.instantiate($typeArgs);

} else if ($typeArgs != null) {

$throwStrongModeError(