|
|
Revert 270925 "Tweaks to ViewManager:"
Broke Windows Debug build; see comments in bug 365012 for details.
> Tweaks to ViewManager:
>
> . OnNodeHierarchyChanged() is only sent for nodes the client cares
> about (see ShouldNotifyOnHierarchyChange for exact details).
> . OnNodeHierarchyChanged() now includes any nodes not yet known to the
> client.
> . Added OnServerChangeIdAdvanced, which is sent if the change id
> advances but the client didn't get a notification (this can happen
> when hierarchy changes are done in other clients that the client
> isn't notified about).
> . OnConnectionEstablished now includes the state of the tree.
>
> BUG= 365012
> TEST=covered by tests
> R=ben@chromium.org
>
> Review URL: https://codereview.chromium.org/288313002
TBR=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270933
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+197 lines, -686 lines) |
Patch |
 |
M |
trunk/src/mojo/mojo_services.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h
|
View
|
|
2 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc
|
View
|
|
3 chunks |
+35 lines, -37 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom
|
View
|
|
2 chunks |
+7 lines, -21 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/view_manager/node.h
|
View
|
|
1 chunk |
+1 line, -12 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/view_manager/node.cc
|
View
|
|
3 chunks |
+1 line, -12 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/view_manager/root_node_manager.h
|
View
|
|
4 chunks |
+13 lines, -22 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/view_manager/root_node_manager.cc
|
View
|
|
3 chunks |
+29 lines, -26 lines |
0 comments
|
Download
|
|
D |
trunk/src/mojo/services/view_manager/type_converters.h
|
View
|
|
1 chunk |
+0 lines, -36 lines |
0 comments
|
Download
|
|
D |
trunk/src/mojo/services/view_manager/type_converters.cc
|
View
|
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/view_manager/view_manager_connection.h
|
View
|
|
4 chunks |
+11 lines, -35 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/view_manager/view_manager_connection.cc
|
View
|
|
14 chunks |
+63 lines, -117 lines |
0 comments
|
Download
|
|
M |
trunk/src/mojo/services/view_manager/view_manager_connection_unittest.cc
|
View
|
|
16 chunks |
+33 lines, -326 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
286973009:
Revert 270925 "Tweaks to ViewManager:" (Closed)
