Tweaks to ViewManager:

Tweaks to ViewManager:

. OnNodeHierarchyChanged() is only sent for nodes the client cares
  about (see ShouldNotifyOnHierarchyChange for exact details).
. OnNodeHierarchyChanged() now includes any nodes not yet known to the
  client.
. Added OnServerChangeIdAdvanced, which is sent if the change id
  advances but the client didn't get a notification (this can happen
  when hierarchy changes are done in other clients that the client
  isn't notified about).
. OnConnectionEstablished now includes the state of the tree.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270925

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271025

[Ben Goodger (Google), 2014-05-15 21:52:29]

lgtm

https://codereview.chromium.org/288313002/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/view_manager_connection.cc (right):

https://codereview.chromium.org/288313002/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/view_manager_connection.cc:238:
GetUnknownNodesFrom(new_parent->GetRoot(), to_send);
I think this is too permissive. Go ahead and land, but I think we will have to
evolve this quite a bit.

[sky, 2014-05-15 21:53:18]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-05-15 21:54:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/288313002/20001

[commit-bot: I haz the power, 2014-05-16 01:21:36]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-16 01:26:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 01:26:36]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[sky, 2014-05-16 03:19:14]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-05-16 03:19:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/288313002/20001

[commit-bot: I haz the power, 2014-05-16 04:37:25]

Change committed as 270925

[sky, 2014-05-16 15:13:33]

This was reverted because of a build error on windows. I've since fixed (diff
between 3 and 4). I'm going to reland.

[sky, 2014-05-16 15:17:11]

Committed patchset #4 manually as r271025 (presubmit successful).