Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869713004:
Add performance_browser_tests to some Mac bots (Closed)
DescriptionAdd performance_browser_tests to some Mac bots
We add this test suite to:
1) Mac Pro 10.11 Perf
2) Mac Retina Perf
3) Mac Air 10.11
BUG=697195
TBR=eyaich@chromium.org
Review-Url: https://codereview.chromium.org/2869713004
Cr-Commit-Position: refs/heads/master@{#470911}
Committed: https://chromium.googlesource.com/chromium/src/+/8e533cacdaf5b39f3d961490878d7a64c7368892
Patch Set 1 #
Total comments: 9
Patch Set 2 : Address review comments #
Messages
Total messages: 24 (14 generated)
nednguyen@google.com changed reviewers: + martiniss@chromium.org
https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... File tools/perf/core/perf_data_generator.py (right): https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:458: ('performance_browser_tests', 'build6-b1') Martiniss: can you help me with picking the lest loaded bots?
miu@chromium.org changed reviewers: + miu@chromium.org
Thanks! Just need an owners change: https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... File tools/perf/core/perf_data_generator.py (right): https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:855: 'hubbe@chromium.org, justinlin@chromium.org, miu@chromium.org', None, The owner list should just be me: 'miu@chromium.org' The others are no longer working in this area.
Description was changed from ========== Add performance_browser_tests to some Mac bots We add this tests to: 1) Mac Pro 10.11 Perf 2) Mac Retina Perf 3) Mac Air 10.11 BUG=697195 ========== to ========== Add performance_browser_tests to some Mac bots We add this test suite to: 1) Mac Pro 10.11 Perf 2) Mac Retina Perf 3) Mac Air 10.11 BUG=697195 ==========
lgtm https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... File tools/perf/core/perf_data_generator.py (right): https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:458: ('performance_browser_tests', 'build6-b1') build8-b1 https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:475: ('performance_browser_tests', 'build128-b1') build132-b1 https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:492: ('performance_browser_tests', 'build124-b1') build126-b1
https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... File tools/perf/core/perf_data_generator.py (right): https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:458: ('performance_browser_tests', 'build6-b1') On 2017/05/09 23:53:29, martiniss wrote: > build8-b1 Done. https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:475: ('performance_browser_tests', 'build128-b1') On 2017/05/09 23:53:29, martiniss wrote: > build132-b1 Done. https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:492: ('performance_browser_tests', 'build124-b1') On 2017/05/09 23:53:29, martiniss wrote: > build126-b1 Done. https://codereview.chromium.org/2869713004/diff/1/tools/perf/core/perf_data_g... tools/perf/core/perf_data_generator.py:855: 'hubbe@chromium.org, justinlin@chromium.org, miu@chromium.org', None, On 2017/05/09 21:18:48, miu wrote: > The owner list should just be me: mailto: The others are no longer > working in this area. Done.
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from martiniss@chromium.org Link to the patchset: https://codereview.chromium.org/2869713004/#ps20001 (title: "Address review comments")
Description was changed from ========== Add performance_browser_tests to some Mac bots We add this test suite to: 1) Mac Pro 10.11 Perf 2) Mac Retina Perf 3) Mac Air 10.11 BUG=697195 ========== to ========== Add performance_browser_tests to some Mac bots We add this test suite to: 1) Mac Pro 10.11 Perf 2) Mac Retina Perf 3) Mac Air 10.11 BUG=697195 TBR=eyaich@chromium.org ==========
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by nednguyen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494496640826130,
"parent_rev": "44395608981a4f8ee6b25f048d69e68cd7b8498a", "commit_rev":
"8e533cacdaf5b39f3d961490878d7a64c7368892"}
Message was sent while issue was closed.
Description was changed from ========== Add performance_browser_tests to some Mac bots We add this test suite to: 1) Mac Pro 10.11 Perf 2) Mac Retina Perf 3) Mac Air 10.11 BUG=697195 TBR=eyaich@chromium.org ========== to ========== Add performance_browser_tests to some Mac bots We add this test suite to: 1) Mac Pro 10.11 Perf 2) Mac Retina Perf 3) Mac Air 10.11 BUG=697195 TBR=eyaich@chromium.org Review-Url: https://codereview.chromium.org/2869713004 Cr-Commit-Position: refs/heads/master@{#470911} Committed: https://chromium.googlesource.com/chromium/src/+/8e533cacdaf5b39f3d961490878d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8e533cacdaf5b39f3d961490878d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
