Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869703004:
Selection API: collapseToStart() and collapseToEnd() should work for text fields. (Closed)
DescriptionSelection API: collapseToStart() and collapseToEnd() should work for text fields.
BUG=716725
Review-Url: https://codereview.chromium.org/2869703004
Cr-Commit-Position: refs/heads/master@{#470824}
Committed: https://chromium.googlesource.com/chromium/src/+/053f34e3a33c62ff262483e92223971aae60de9d
Patch Set 1 : . #
Messages
Total messages: 25 (15 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
tkent@chromium.org changed reviewers: + xiaochengh@chromium.org, yosin@chromium.org
yosin@ or xiaochengh@, would you review this please?
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
This change makes Selection#collapsTo{Start,End}() into two parts:
- Selection in Document tree, DocumentCachedRange() != nullptr
Using cached range and use start/end position
We could do without using Range but it doesn't work well when cached range
calculated from
VisibleSelection
- Selection in Shadow DOM Tree
Behavior of selection in shadow DOM tree isn't spec'ed. This patch does what
other browsers do.
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/10 at 00:59:45, yosin wrote:
> lgtm
>
> This change makes Selection#collapsTo{Start,End}() into two parts:
> - Selection in Document tree, DocumentCachedRange() != nullptr
> Using cached range and use start/end position
> We could do without using Range but it doesn't work well when cached range
calculated from
> VisibleSelection
> - Selection in Shadow DOM Tree
> Behavior of selection in shadow DOM tree isn't spec'ed. This patch does what
other browsers do.
That's right. Ideally the |else| part of the code should work well in a case of
Document selection too, however dropping the cached range will cause Range
creation with VisibleSelection later, and cause many test failures in
wpt/selection/.
The CQ bit was unchecked by commit-bot@chromium.org
Exhausted attempt retry quota accross all builders (set as global_retry_quota=2 in cq.cfg of this project)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494476269279710,
"parent_rev": "570b67158dabf2d9f10bb12ac68762e973ed63ad", "commit_rev":
"053f34e3a33c62ff262483e92223971aae60de9d"}
Message was sent while issue was closed.
Description was changed from ========== Selection API: collapseToStart() and collapseToEnd() should work for text fields. BUG=716725 ========== to ========== Selection API: collapseToStart() and collapseToEnd() should work for text fields. BUG=716725 Review-Url: https://codereview.chromium.org/2869703004 Cr-Commit-Position: refs/heads/master@{#470824} Committed: https://chromium.googlesource.com/chromium/src/+/053f34e3a33c62ff262483e92223... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/053f34e3a33c62ff262483e92223... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
