Use TaskShutdownBehavior::BLOCK_SHUTDOWN in content::CreateCookieStore().

Use TaskShutdownBehavior::BLOCK_SHUTDOWN in content::CreateCookieStore().

The SequencedTaskRunner created in content::CreateCookieStore() is
used to run a task that closes an sql::Connection. That task cannot
be skipped on shutdown.

BUG=717740
Review-Url: https://codereview.chromium.org/2869703003
Cr-Commit-Position: refs/heads/master@{#469989}
Committed: https://chromium.googlesource.com/chromium/src/+/cc174e5c89d6c5f8443ff8c4efcb58749029a8c8

[fdoray, 2017-05-08 14:31:28]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 14:32:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-08 14:36:55]

fdoray@chromium.org changed reviewers:
+ jam@chromium.org, mmenke@chromium.org

[fdoray, 2017-05-08 14:36:55]

PTAL

[mmenke, 2017-05-08 14:38:59]

LGTM.  Was the original conversion done by hand or by a script?  Just wondering
if there may be other places that lost the BLOCK_SHUTDOWN behavior.

[fdoray, 2017-05-08 14:49:57]

On 2017/05/08 14:38:59, mmenke wrote:
> LGTM.  Was the original conversion done by hand or by a script?  Just
wondering
> if there may be other places that lost the BLOCK_SHUTDOWN behavior.

The original conversion was made by a script. The script keeps the shutdown
behavior when specified explicitly. However, the default shutdown behavior (used
when not specified explicitly) is BLOCK_SHUTDOWN in the blocking pool and
SKIP_ON_SHUTDOWN in task scheduler. Most of the time, code is fine with this
change of default. I rely on reviewers to tell me when this is wrong: 

"This CL was generated automatically.

Please make sure that the appropriate TaskTraits are used to post tasks.
https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h
If everything looks good, please lgtm and CQ this CL. Otherwise, tell
us what's wrong."

I will clearly highlight the change of default shutdown behavior in future CLs.

[jam, 2017-05-08 15:11:35]

lgtm

[fdoray, 2017-05-08 15:17:30]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-05-08 15:17:36]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:18:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 15:35:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494256656052380,
"parent_rev": "7d433cc2ac0b3e36e6753e84fbfc9253aac646d8", "commit_rev":
"cc174e5c89d6c5f8443ff8c4efcb58749029a8c8"}

[commit-bot: I haz the power, 2017-05-08 15:35:45]

Description was changed from

==========
Use TaskShutdownBehavior::BLOCK_SHUTDOWN in content::CreateCookieStore().

The SequencedTaskRunner created in content::CreateCookieStore() is
used to run a task that closes an sql::Connection. That task cannot
be skipped on shutdown.

BUG=717740
==========

to

==========
Use TaskShutdownBehavior::BLOCK_SHUTDOWN in content::CreateCookieStore().

The SequencedTaskRunner created in content::CreateCookieStore() is
used to run a task that closes an sql::Connection. That task cannot
be skipped on shutdown.

BUG=717740

Review-Url: https://codereview.chromium.org/2869703003
Cr-Commit-Position: refs/heads/master@{#469989}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc174e5c89d6c5f8443ff8c4efcb...
==========

[commit-bot: I haz the power, 2017-05-08 15:35:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cc174e5c89d6c5f8443ff8c4efcb...