Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869673003:
Fix system active time reporting for app kiosks (Closed)
|
Created:
3 years, 7 months ago by Ivan Šandrk Modified:
3 years, 7 months ago Reviewers:
Andrew T Wilson (Slow) CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix system active time reporting for app kiosks
Currently system active time is reported as the non-idle time, but for kiosks running 24x7 this is misleading since they usually run without any user interaction. Switch kiosks to report total uptime as the system active time.
BUG=701264
Review-Url: https://codereview.chromium.org/2869673003
Cr-Commit-Position: refs/heads/master@{#470526}
Committed: https://chromium.googlesource.com/chromium/src/+/945c444f7cad54e08c188d4d4744b344fc463bc5
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Updated tests #Patch Set 4 : Removed a duplicate test #
Total comments: 1
Messages
Total messages: 25 (21 generated)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
isandrk@chromium.org changed reviewers: + atwilson@chromium.org
Hey Drew, ptal! Should be fine now. The fix was much simpler, turns out I hastily forgot to setup chromeos::LoginState. https://codereview.chromium.org/2869673003/diff/80001/chrome/browser/chromeos... File chrome/browser/chromeos/policy/device_status_collector_browsertest.cc (left): https://codereview.chromium.org/2869673003/diff/80001/chrome/browser/chromeos... chrome/browser/chromeos/policy/device_status_collector_browsertest.cc:611: TEST_F(DeviceStatusCollectorTest, Times) { I removed this test as it's the same as MixedStates. Btw I dislike how this tool produces diff, it's a bit confusing on this one.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by isandrk@chromium.org
The CQ bit was checked by isandrk@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494407832172480,
"parent_rev": "bf020bf21b6829abe5443dd46ffee60c7d32ec09", "commit_rev":
"945c444f7cad54e08c188d4d4744b344fc463bc5"}
Message was sent while issue was closed.
Description was changed from ========== Fix system active time reporting for app kiosks Currently system active time is reported as the non-idle time, but for kiosks running 24x7 this is misleading since they usually run without any user interaction. Switch kiosks to report total uptime as the system active time. BUG=701264 ========== to ========== Fix system active time reporting for app kiosks Currently system active time is reported as the non-idle time, but for kiosks running 24x7 this is misleading since they usually run without any user interaction. Switch kiosks to report total uptime as the system active time. BUG=701264 Review-Url: https://codereview.chromium.org/2869673003 Cr-Commit-Position: refs/heads/master@{#470526} Committed: https://chromium.googlesource.com/chromium/src/+/945c444f7cad54e08c188d4d4744... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/945c444f7cad54e08c188d4d4744... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
