Use OnceCallback on Mojo interfaces in //components/autofill

Use OnceCallback on Mojo interfaces in //components/autofill
    
This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/autofill starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
Review-Url: https://codereview.chromium.org/2869673002
Cr-Commit-Position: refs/heads/master@{#471170}
Committed: https://chromium.googlesource.com/chromium/src/+/4772a01d5433374cd8dd6f4a9fedaff7eafbd5a7

[tzik, 2017-05-08 07:53:01]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 07:53:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 10:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 10:08:57]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-05-09 07:11:41]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 07:12:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-09 07:14:42]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //components/autofill
==========

to

==========
Use OnceCallback on Mojo interfaces in //components/autofill
    
This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/autofill starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

[tzik, 2017-05-09 07:14:42]

tzik@chromium.org changed reviewers:
+ sebsg@chromium.org

[tzik, 2017-05-09 07:16:34]

tzik@chromium.org changed reviewers:
+ engedy@chromium.org

[engedy, 2017-05-09 08:58:07]

*password_manager* LGTM.

[commit-bot: I haz the power, 2017-05-09 09:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 09:19:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sebsg, 2017-05-10 14:04:45]

autofill lgtm

[tzik, 2017-05-11 07:35:52]

I forgot to publish the request. Thanks for reviewing engedy and sebsg!

Adding dcheng as a SECURITY_OWNER, PTAL to
autofill_types_struct_traits_unittest.cc.

[tzik, 2017-05-11 07:36:09]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2017-05-11 07:36:52]

Resending after actually added dcheng. PTAL to
autofill_types_struct_traits_unittest.cc.

[tzik, 2017-05-11 08:02:06]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 08:02:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 09:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 09:38:51]

Dry run: This issue passed the CQ dry run.

[sebsg, 2017-05-11 14:53:40]

still lgtm for autofill

[dcheng, 2017-05-11 21:00:28]

ipc security lgtm

[tzik, 2017-05-12 01:37:28]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-05-12 01:37:28]

The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/2869673002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-12 01:38:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 01:46:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494553048072290,
"parent_rev": "068131adfe61daa07b2a2b16171fcded6877c787", "commit_rev":
"4772a01d5433374cd8dd6f4a9fedaff7eafbd5a7"}

[commit-bot: I haz the power, 2017-05-12 01:46:57]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //components/autofill
    
This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/autofill starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

to

==========
Use OnceCallback on Mojo interfaces in //components/autofill
    
This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/autofill starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2869673002
Cr-Commit-Position: refs/heads/master@{#471170}
Committed:
https://chromium.googlesource.com/chromium/src/+/4772a01d5433374cd8dd6f4a9fed...
==========

[commit-bot: I haz the power, 2017-05-12 01:46:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4772a01d5433374cd8dd6f4a9fed...