ResourceFetcher::Start should be given a WebLocalFrame

ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument(). This is a preliminary change to use
blink::FetchContext::CreateURLLoader from content::ResourceFetcherImpl.


BUG=712913
R=kinuko@chromium.org

Review-Url: https://codereview.chromium.org/2869663002
Cr-Commit-Position: refs/heads/master@{#469952}
Committed: https://chromium.googlesource.com/chromium/src/+/505d1e6979447633985e1a297568c04d993a0f48

[yhirano, 2017-05-08 06:07:55]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 06:08:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-05-08 06:09:11]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

... hence this CL adds some DCHECKs.

Currently the function calls

frame->GetDocument().FirstPartyForCookies()

which requires a non-null WebDocument which requires |frame| to be local.

BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

... hence this CL adds some DCHECKs.

Currently the function calls

frame->GetDocument().FirstPartyForCookies()

which requires a non-null WebDocument, which means |frame| should be local.

BUG=712913
R=kinuko@chromium.org
==========

[yhirano, 2017-05-08 07:11:48]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[yhirano, 2017-05-08 07:12:01]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

... hence this CL adds some DCHECKs.

Currently the function calls

frame->GetDocument().FirstPartyForCookies()

which requires a non-null WebDocument, which means |frame| should be local.

BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame instead of WebFrame

BUG=712913
R=kinuko@chromium.org
==========

[commit-bot: I haz the power, 2017-05-08 07:12:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-05-08 07:16:20]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame instead of WebFrame

BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

BUG=712913
R=kinuko@chromium.org
==========

[yhirano, 2017-05-08 07:18:14]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten
from
GetDocument() call. This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

[yhirano, 2017-05-08 07:18:26]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten
from
GetDocument() call. This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument() call. This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

[yhirano, 2017-05-08 07:18:39]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument() call. This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument() call. This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

[yhirano, 2017-05-08 07:18:59]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument() call. This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument(). This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

[kinuko, 2017-05-08 09:07:43]

lgtm

[yhirano, 2017-05-08 09:26:06]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument(). This is a preliminary change to use
blink::FetchContext::CreateURLLoader.


BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument(). This is a preliminary change to use
blink::FetchContext::CreateURLLoader from content::ResourceFetcherImpl.


BUG=712913
R=kinuko@chromium.org
==========

[yhirano, 2017-05-08 09:26:20]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2017-05-08 09:26:20]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-05-08 09:26:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 10:37:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494235580563470,
"parent_rev": "7b25452790cbea67af535d523b49bcd60e0afe56", "commit_rev":
"505d1e6979447633985e1a297568c04d993a0f48"}

[commit-bot: I haz the power, 2017-05-08 10:38:02]

Description was changed from

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument(). This is a preliminary change to use
blink::FetchContext::CreateURLLoader from content::ResourceFetcherImpl.


BUG=712913
R=kinuko@chromium.org
==========

to

==========
ResourceFetcher::Start should be given a WebLocalFrame

Actually it is already assumed implicitly by using the WebDocument gotten from
GetDocument(). This is a preliminary change to use
blink::FetchContext::CreateURLLoader from content::ResourceFetcherImpl.


BUG=712913
R=kinuko@chromium.org

Review-Url: https://codereview.chromium.org/2869663002
Cr-Commit-Position: refs/heads/master@{#469952}
Committed:
https://chromium.googlesource.com/chromium/src/+/505d1e6979447633985e1a297568...
==========

[commit-bot: I haz the power, 2017-05-08 10:38:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/505d1e6979447633985e1a297568...