Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2869633003: [Sync] Hook UserEvents into sync. (Closed)

Created:
3 years, 7 months ago by skym
Modified:
3 years, 7 months ago
Reviewers:
Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Hook UserEvents into sync. If the given feature is enabled, register UserEvents with sync. The feature defaults to disabled, so this will not impact anyone yet. Since Sync's internals have not been changed to handle commit only types yet, UserEvents are still non-functional even after this change. BUG=701032 Review-Url: https://codereview.chromium.org/2869633003 Cr-Commit-Position: refs/heads/master@{#470717} Committed: https://chromium.googlesource.com/chromium/src/+/3de308cf223322e364f6c5621c84443190a8288a

Patch Set 1 #

Patch Set 2 : Self review. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -9 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/browser_sync/profile_sync_components_factory_impl.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M components/sync/driver/sync_driver_switches.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/sync_driver_switches.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M components/sync/user_events/user_event_service.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M components/sync/user_events/user_event_service_unittest.cc View 1 2 4 chunks +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
skym
PTAL
3 years, 7 months ago (2017-05-08 22:27:47 UTC) #4
Patrick Noland
lgtm
3 years, 7 months ago (2017-05-08 22:47:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869633003/40001
3 years, 7 months ago (2017-05-10 15:26:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/440702)
3 years, 7 months ago (2017-05-10 17:29:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869633003/40001
3 years, 7 months ago (2017-05-10 19:52:17 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 21:35:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3de308cf223322e364f6c5621c84...

Powered by Google App Engine
This is Rietveld 408576698