Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2869633002: (DO NOT LAND) Revert of Generate StyleBackgroundData in ComputedStyleBase. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate StyleBackgroundData in ComputedStyleBase. (patchset #1 id:1 of https://codereview.chromium.org/2861623002/ ) Reason for revert: Testing Original issue's description: > Generate StyleBackgroundData in ComputedStyleBase. > > This patch generates the following fields as part of a group: > - background ('storage_only' of type FillLayer) > - background_color ('storage_only' of type Color) > > Since both fields correspond to shorthands, we specify them in > ComputedStyleExtraFields.json5. > > All deleted code are correspondingly generated in > ComputedStyleBase, apart from the line > > background_data_(o.background_data_) > > which is implicit in the compiler generated ComputedStyleBase > copy constructor. > > Diff of generated files: > https://gist.github.com/darrnshn/c2d2e7f7429b6281987c8f1ff6e2c313/revisions > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2861623002 > Cr-Commit-Position: refs/heads/master@{#469566} > Committed: https://chromium.googlesource.com/chromium/src/+/8976caef37205d31c6b73aec7f008a652671f076 TBR=meade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shend
3 years, 7 months ago (2017-05-08 02:54:32 UTC) #1
Created Revert of Generate StyleBackgroundData in ComputedStyleBase.

Powered by Google App Engine
This is Rietveld 408576698