Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2861623002: Generate StyleBackgroundData in ComputedStyleBase. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate StyleBackgroundData in ComputedStyleBase. This patch generates the following fields as part of a group: - background ('storage_only' of type FillLayer) - background_color ('storage_only' of type Color) Since both fields correspond to shorthands, we specify them in ComputedStyleExtraFields.json5. All deleted code are correspondingly generated in ComputedStyleBase, apart from the line background_data_(o.background_data_) which is implicit in the compiler generated ComputedStyleBase copy constructor. Diff of generated files: https://gist.github.com/darrnshn/c2d2e7f7429b6281987c8f1ff6e2c313/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2861623002 Cr-Commit-Position: refs/heads/master@{#469566} Committed: https://chromium.googlesource.com/chromium/src/+/8976caef37205d31c6b73aec7f008a652671f076

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -34 lines) Patch
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +0 lines, -4 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
shend
Hi Eddy, PTAL :) (second try :P)
3 years, 7 months ago (2017-05-03 05:04:48 UTC) #3
meade_UTC10
lgtm with a question https://codereview.chromium.org/2861623002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.cpp File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right): https://codereview.chromium.org/2861623002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.cpp#newcode80 third_party/WebKit/Source/core/style/ComputedStyle.cpp:80: void* data_ref_svg_style; This CL affects ...
3 years, 7 months ago (2017-05-04 04:54:38 UTC) #9
shend
On 2017/05/04 at 04:54:38, meade wrote: > lgtm with a question > > https://codereview.chromium.org/2861623002/diff/1/third_party/WebKit/Source/core/style/ComputedStyle.cpp > ...
3 years, 7 months ago (2017-05-04 23:47:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861623002/1
3 years, 7 months ago (2017-05-04 23:48:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8976caef37205d31c6b73aec7f008a652671f076
3 years, 7 months ago (2017-05-05 01:31:34 UTC) #15
shend
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2869633002/ by shend@chromium.org. ...
3 years, 7 months ago (2017-05-08 02:54:31 UTC) #16
shend
3 years, 7 months ago (2017-05-08 02:56:33 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2872443002/ by shend@chromium.org.

The reason for reverting is: Testing.

Powered by Google App Engine
This is Rietveld 408576698