Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: runtime/vm/debugger.h

Issue 2869573002: Use latent breakpoints list when looking up or removing breakpoints. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | runtime/vm/debugger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.h
diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h
index 9bf4d969dfa8ffd4eb96a81274ec0ac9c8b92a34..3468041e374b1597c38c0944111c7afdc70e4450 100644
--- a/runtime/vm/debugger.h
+++ b/runtime/vm/debugger.h
@@ -489,7 +489,9 @@ class Debugger {
void RemoveBreakpoint(intptr_t bp_id);
+ bool RemoveBreakpointFromTheList(intptr_t bp_id, BreakpointLocation** list);
Breakpoint* GetBreakpointById(intptr_t id);
+ Breakpoint* GetBreakpointByIdInTheList(intptr_t id, BreakpointLocation* list);
siva 2017/05/08 18:28:18 Should these list variants be private methods as w
aam 2017/05/08 20:17:47 Done.
void MaybeAsyncStepInto(const Closure& async_op);
void AsyncStepInto(const Closure& async_op);
@@ -598,6 +600,8 @@ class Debugger {
RawCode* GetPatchedStubAddress(uword breakpoint_address);
void PrintBreakpointsToJSONArray(JSONArray* jsarr) const;
+ void PrintBreakpointsListToJSONArray(BreakpointLocation* sbpt,
+ JSONArray* jsarr) const;
siva 2017/05/08 18:28:18 Ditto comment about making this a private method.
aam 2017/05/08 20:17:47 Done.
void PrintSettingsToJSONObject(JSONObject* jsobj) const;
static bool IsDebuggable(const Function& func);
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | runtime/vm/debugger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698