Use latent breakpoints list when looking up or removing breakpoints.

runtime/vm/debugger.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_DEBUGGER_H_
 #define RUNTIME_VM_DEBUGGER_H_
 
 #include "include/dart_tools_api.h"
 
 #include "vm/object.h"
@@ skipping 471 matching lines @@
                                      intptr_t line_number,
                                      intptr_t column_number);
   RawError* OneTimeBreakAtEntry(const Function& target_function);
 
   BreakpointLocation* BreakpointLocationAtLineCol(const String& script_url,
                                                   intptr_t line_number,
                                                   intptr_t column_number);
 
 
   void RemoveBreakpoint(intptr_t bp_id);
+  bool RemoveBreakpointFromTheList(intptr_t bp_id, BreakpointLocation** list);
   Breakpoint* GetBreakpointById(intptr_t id);
+  Breakpoint* GetBreakpointByIdInTheList(intptr_t id, BreakpointLocation* list);

[siva, 2017/05/08 18:28:18]

Should these list variants be private methods as we don't expect them to be
called directly?

[aam, 2017/05/08 20:17:47]

Done.

 
   void MaybeAsyncStepInto(const Closure& async_op);
   void AsyncStepInto(const Closure& async_op);
 
   void Continue();
 
   bool SetResumeAction(ResumeAction action,
                        intptr_t frame_index = 1,
                        const char** error = NULL);
 
@@ skipping 88 matching lines @@
   // Pause execution due to an uncaught exception.
   void PauseException(const Instance& exc);
 
   // Pause execution due to a call to the debugger() function from
   // Dart.
   void PauseDeveloper(const String& msg);
 
   RawCode* GetPatchedStubAddress(uword breakpoint_address);
 
   void PrintBreakpointsToJSONArray(JSONArray* jsarr) const;
+  void PrintBreakpointsListToJSONArray(BreakpointLocation* sbpt,
+                                       JSONArray* jsarr) const;

[siva, 2017/05/08 18:28:18]

Ditto comment about making this a private method.

[aam, 2017/05/08 20:17:47]

Done.

   void PrintSettingsToJSONObject(JSONObject* jsobj) const;
 
   static bool IsDebuggable(const Function& func);
 
   intptr_t limitBreakpointId() { return next_id_; }
 
   // Callback to the debugger to continue frame rewind, post-deoptimization.
   void RewindPostDeopt();
 
   static DebuggerStackTrace* CollectAwaiterReturnStackTrace();
@@ skipping 173 matching lines @@
 
   friend class Isolate;
   friend class BreakpointLocation;
   DISALLOW_COPY_AND_ASSIGN(Debugger);
 };
 
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_DEBUGGER_H_