Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869563004:
Deflake WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling. (Closed)
|
Created:
3 years, 7 months ago by Avi (use Gerrit) Modified:
3 years, 7 months ago Reviewers:
boliu CC:
chromium-reviews, android-webview-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDeflake WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling.
This reverts commit da115c68f2b4e3fcb46daf54a6dc8aa5df2ddcd4 which added retries, and it makes sure the touch on the view is processed before proceeding.
BUG=719308
Review-Url: https://codereview.chromium.org/2869563004
Cr-Commit-Position: refs/heads/master@{#470208}
Committed: https://chromium.googlesource.com/chromium/src/+/6a8c3317e754288840610dd169c3a93d4d34aeb1
Patch Set 1 #Patch Set 2 : rev #Patch Set 3 : 100 col #Patch Set 4 : throw #Messages
Total messages: 22 (18 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
avi@chromium.org changed reviewers: + boliu@chromium.org
lgtm
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494292096628640,
"parent_rev": "1a97290bbc1c6d83e4b7f9d84bd208a28acde4a7", "commit_rev":
"6a8c3317e754288840610dd169c3a93d4d34aeb1"}
Message was sent while issue was closed.
Description was changed from ========== Deflake WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling. This reverts commit da115c68f2b4e3fcb46daf54a6dc8aa5df2ddcd4 which added retries, and it makes sure the touch on the view is processed before proceeding. BUG=719308 ========== to ========== Deflake WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling. This reverts commit da115c68f2b4e3fcb46daf54a6dc8aa5df2ddcd4 which added retries, and it makes sure the touch on the view is processed before proceeding. BUG=719308 Review-Url: https://codereview.chromium.org/2869563004 Cr-Commit-Position: refs/heads/master@{#470208} Committed: https://chromium.googlesource.com/chromium/src/+/6a8c3317e754288840610dd169c3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/6a8c3317e754288840610dd169c3... |
