Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/shelf/shelf_model_unittest.cc

Issue 2869473002: Fix crash on openning settings when DCHECK is on. (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/app_list_shelf_item_delegate.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc » ('j') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_model_unittest.cc
diff --git a/ash/shelf/shelf_model_unittest.cc b/ash/shelf/shelf_model_unittest.cc
index 12177d7dd60336a9eaf00533fd1c24979229194d..2632123a3482f31810a9418ef63b0c789cb925a3 100644
--- a/ash/shelf/shelf_model_unittest.cc
+++ b/ash/shelf/shelf_model_unittest.cc
@@ -15,6 +15,8 @@ namespace ash {
namespace {
+constexpr char kAppListId[] = "eiiblffaiacobmjejhcoookmokblahea";
msw 2017/05/05 23:54:55 nit: use the new jlfapfmkapbjlfbpjedlinehodkccjee
khmel 2017/05/06 01:10:40 Ohh :)
+
// ShelfModelObserver implementation that tracks what message are invoked.
class TestShelfModelObserver : public ShelfModelObserver {
public:
@@ -69,7 +71,7 @@ class ShelfModelTest : public testing::Test {
ShelfItem item;
item.type = TYPE_APP_LIST;
- item.id = ShelfID("AppListId");
+ item.id = ShelfID(kAppListId);
model_->Add(item);
EXPECT_EQ(1, model_->item_count());
« no previous file with comments | « ash/shelf/app_list_shelf_item_delegate.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc » ('j') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698