Fix crash on openning settings when DCHECK is on.

ash/shelf/shelf_model_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_model.h"
 
 #include <set>
 #include <string>
 
 #include "ash/shelf/shelf_model_observer.h"
 #include "base/strings/stringprintf.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace ash {
 
 namespace {
 
+constexpr char kAppListId[] = "eiiblffaiacobmjejhcoookmokblahea";

[msw, 2017/05/05 23:54:55]

nit: use the new jlfapfmkapbjlfbpjedlinehodkccjee

[khmel, 2017/05/06 01:10:40]

Ohh :) 

+
 // ShelfModelObserver implementation that tracks what message are invoked.
 class TestShelfModelObserver : public ShelfModelObserver {
  public:
   TestShelfModelObserver() {}
 
   // Returns a string description of the changes that have occurred since this
   // was last invoked. Resets state to initial state.
   std::string StateStringAndClear() {
     std::string result;
     AddToResult("added=%d", added_count_, &result);
@@ skipping 34 matching lines @@
   ShelfModelTest() {}
   ~ShelfModelTest() override {}
 
   void SetUp() override {
     model_.reset(new ShelfModel);
     observer_.reset(new TestShelfModelObserver);
     EXPECT_EQ(0, model_->item_count());
 
     ShelfItem item;
     item.type = TYPE_APP_LIST;
-    item.id = ShelfID("AppListId");
+    item.id = ShelfID(kAppListId);
     model_->Add(item);
     EXPECT_EQ(1, model_->item_count());
 
     model_->AddObserver(observer_.get());
   }
 
   void TearDown() override {
     observer_.reset();
     model_.reset();
   }
@@ skipping 345 matching lines @@
 
   // Unpinning the same app id again should have no change.
   model_->UnpinAppWithID(app_id);
   EXPECT_FALSE(model_->IsAppPinned(app_id));
   EXPECT_EQ(2, model_->item_count());
   EXPECT_EQ(TYPE_APP, model_->items()[index].type);
   EXPECT_EQ(item.id, model_->items()[index].id);
 }
 
 }  // namespace ash