Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: ash/shelf/shelf_model_unittest.cc

Issue 2869473002: Fix crash on openning settings when DCHECK is on. (Closed)
Patch Set: up Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_model_unittest.cc
diff --git a/ash/shelf/shelf_model_unittest.cc b/ash/shelf/shelf_model_unittest.cc
index 12177d7dd60336a9eaf00533fd1c24979229194d..efb67a18d58a339e6bf48e4bf68108855641ae72 100644
--- a/ash/shelf/shelf_model_unittest.cc
+++ b/ash/shelf/shelf_model_unittest.cc
@@ -69,7 +69,7 @@ class ShelfModelTest : public testing::Test {
ShelfItem item;
item.type = TYPE_APP_LIST;
- item.id = ShelfID("AppListId");
+ item.id = ShelfID(AppListShelfItemDelegate::kAppListId);
msw 2017/05/05 21:45:04 nit: include the header for this (or use something
khmel 2017/05/05 22:45:12 Done.
model_->Add(item);
EXPECT_EQ(1, model_->item_count());

Powered by Google App Engine
This is Rietveld 408576698