Fix crash on openning settings when DCHECK is on.

ash/shelf/shelf_model_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_model.h"
 
 #include <set>
 #include <string>
 
 #include "ash/shelf/shelf_model_observer.h"
@@ skipping 51 matching lines @@
   ShelfModelTest() {}
   ~ShelfModelTest() override {}
 
   void SetUp() override {
     model_.reset(new ShelfModel);
     observer_.reset(new TestShelfModelObserver);
     EXPECT_EQ(0, model_->item_count());
 
     ShelfItem item;
     item.type = TYPE_APP_LIST;
-    item.id = ShelfID("AppListId");
+    item.id = ShelfID(AppListShelfItemDelegate::kAppListId);

[msw, 2017/05/05 21:45:04]

nit: include the header for this (or use something like kDummyAppId or define a
string copy here, and make kAppListId private to the cc file again)

[khmel, 2017/05/05 22:45:12]

Done.

     model_->Add(item);
     EXPECT_EQ(1, model_->item_count());
 
     model_->AddObserver(observer_.get());
   }
 
   void TearDown() override {
     observer_.reset();
     model_.reset();
   }
@@ skipping 345 matching lines @@
 
   // Unpinning the same app id again should have no change.
   model_->UnpinAppWithID(app_id);
   EXPECT_FALSE(model_->IsAppPinned(app_id));
   EXPECT_EQ(2, model_->item_count());
   EXPECT_EQ(TYPE_APP, model_->items()[index].type);
   EXPECT_EQ(item.id, model_->items()[index].id);
 }
 
 }  // namespace ash