Cause Skia to use a smaller glyph cache on low-end Android

Cause Skia to use a smaller glyph cache on low-end Android

Currently Skia uses an up-to 8MB/texture glyph cache on all Android
devices. To save memory on low-end devices we are switching to an
up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2869443003
Cr-Commit-Position: refs/heads/master@{#470022}
Committed: https://chromium.googlesource.com/chromium/src/+/9ce0013f7cb1f236cffbbae7bf43a6b7a8d09ef0

[ericrk, 2017-05-05 23:17:16]

Description was changed from

==========
Cause Skia to use a smaller texture cache on low-end Android

Currently Skia uses a 2048x2048 texture cache for low-end Android. To
save memory on these devices we are dropping to a 1024x512 cache.

BUG=717178
==========

to

==========
Cause Skia to use a smaller texture cache on low-end Android

Currently Skia uses a 2048x2048 texture cache for low-end Android. To
save memory on these devices we are dropping to a 1024x512 cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2017-05-05 23:20:47]

ericrk@chromium.org changed reviewers:
+ vmiura@chromium.org

[ericrk, 2017-05-05 23:21:04]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 23:22:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmiura, 2017-05-05 23:29:57]

LGTM

Nit: Perhaps mention Glyph cache specifically in the description.

Say, Skia doesn't use 4 bytes-per-pixel textures for fonts does it?

[commit-bot: I haz the power, 2017-05-05 23:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:30:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[ericrk, 2017-05-05 23:44:36]

Description was changed from

==========
Cause Skia to use a smaller texture cache on low-end Android

Currently Skia uses a 2048x2048 texture cache for low-end Android. To
save memory on these devices we are dropping to a 1024x512 cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Cause Skia to use a smaller texture cache on low-end Android

Currently Skia uses an up-to 8MB texture cache for low-end Android. To
save memory on these devices we are dropping to an up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2017-05-05 23:48:03]

Description was changed from

==========
Cause Skia to use a smaller texture cache on low-end Android

Currently Skia uses an up-to 8MB texture cache for low-end Android. To
save memory on these devices we are dropping to an up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Cause Skia to use a smaller glyph cache on low-end Android

Currently Skia uses an up-to 8MB glyph cache texture on all Android
devices. To save memory on low-end devices we are switching to an
up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2017-05-05 23:48:18]

Description was changed from

==========
Cause Skia to use a smaller glyph cache on low-end Android

Currently Skia uses an up-to 8MB glyph cache texture on all Android
devices. To save memory on low-end devices we are switching to an
up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Cause Skia to use a smaller glyph cache on low-end Android

Currently Skia uses an up-to 8MB/texture glyph cache on all Android
devices. To save memory on low-end devices we are switching to an
up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2017-05-05 23:49:22]

On 2017/05/05 23:29:57, vmiura wrote:
> LGTM
> 
> Nit: Perhaps mention Glyph cache specifically in the description.
> 
> Say, Skia doesn't use 4 bytes-per-pixel textures for fonts does it?

On 2017/05/05 23:29:57, vmiura wrote:
> LGTM
> 
> Nit: Perhaps mention Glyph cache specifically in the description.
Oops, good call - updated. 
> 
> Say, Skia doesn't use 4 bytes-per-pixel textures for fonts does it?

It only does if necessary. By default, it uses an A8 texture.
Sizing is done a bit magically in Skia, but the number we pass in is
the maximum texture size.

With the values in this CL, the potential caches generated will be:

Normal Android:
2048x2048x1 = A8 1 byte-per-pixel cache = 4MB Cache
2048x1024x4 = RGBA 4 byte-per-pixel cache = 8MB Cache

Low-end Android:
1024x1024x1 = A8 1 byte-per-pixel cache = 1MB Cache
1024x512x4  = RGBA 4 byte-per-pixel cache = 2MB cache

[ericrk, 2017-05-07 19:53:57]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-07 19:54:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-07 20:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 20:02:10]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2017-05-07 20:14:42]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-07 20:14:43]

The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org
Link to the patchset: https://codereview.chromium.org/2869443003/#ps20001
(title: "rename fix")

[commit-bot: I haz the power, 2017-05-07 20:14:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-07 21:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 21:26:13]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ericrk, 2017-05-07 23:34:05]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-07 23:34:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 00:51:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 00:51:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-05-08 01:06:00]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-08 01:06:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 02:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 02:26:29]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-05-08 15:52:24]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:53:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:01:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494258744292640,
"parent_rev": "8c5805290290f2e7749c27ee7ea005a980398947", "commit_rev":
"9ce0013f7cb1f236cffbbae7bf43a6b7a8d09ef0"}

[commit-bot: I haz the power, 2017-05-08 17:01:55]

Description was changed from

==========
Cause Skia to use a smaller glyph cache on low-end Android

Currently Skia uses an up-to 8MB/texture glyph cache on all Android
devices. To save memory on low-end devices we are switching to an
up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Cause Skia to use a smaller glyph cache on low-end Android

Currently Skia uses an up-to 8MB/texture glyph cache on all Android
devices. To save memory on low-end devices we are switching to an
up-to 2MB cache.

BUG=717178
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2869443003
Cr-Commit-Position: refs/heads/master@{#470022}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ce0013f7cb1f236cffbbae7bf43...
==========

[commit-bot: I haz the power, 2017-05-08 17:01:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ce0013f7cb1f236cffbbae7bf43...