Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2869433002: [LayoutNG] Add Font::GetTextIntercepts for LayoutNG (Closed)

Created:
3 years, 7 months ago by eae
Modified:
3 years, 7 months ago
Reviewers:
drott
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add Font::GetTextIntercepts for LayoutNG Add a version of the Font::GetTextIntercepts method that takes fragments for LayoutNG. Breaks out intercepts logic into GetTextInterceptsInternal helper function that is shared between the TextRun & TextFragment impls. R=drott@chromium.org BUG=714962 Review-Url: https://codereview.chromium.org/2869433002 Cr-Commit-Position: refs/heads/master@{#470025} Committed: https://chromium.googlesource.com/chromium/src/+/9dc9a99a5f4e79fbccbb7c1a41bc0d32cd6bff96

Patch Set 1 #

Patch Set 2 : Fix compiler warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 3 chunks +41 lines, -18 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
eae
3 years, 7 months ago (2017-05-05 18:32:48 UTC) #1
eae
I did, thanks!
3 years, 7 months ago (2017-05-05 21:18:07 UTC) #10
drott
lgtm
3 years, 7 months ago (2017-05-08 13:13:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869433002/40001
3 years, 7 months ago (2017-05-08 15:27:13 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:09:35 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9dc9a99a5f4e79fbccbb7c1a41bc...

Powered by Google App Engine
This is Rietveld 408576698