Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: content/common/content_security_policy/csp_context.h

Issue 2869423002: PlzNavigate: Do not disclose urls between cross-origin renderers. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/content_security_policy/csp_context.h
diff --git a/content/common/content_security_policy/csp_context.h b/content/common/content_security_policy/csp_context.h
index cc5f3b50873a7a62ce363cf3cf9f14f74ce28827..54cd947c3de0e28367b3e8ec4ffb64a888e261d9 100644
--- a/content/common/content_security_policy/csp_context.h
+++ b/content/common/content_security_policy/csp_context.h
@@ -55,6 +55,11 @@ class CONTENT_EXPORT CSPContext {
virtual bool SchemeShouldBypassCSP(const base::StringPiece& scheme);
+ // For security reasons, some urls must not be disclosed in console error
+ // messages, source location and reports. When this function returns false,
alexmos 2017/05/10 22:33:08 Note: using those URLs in console error messages i
arthursonzogni 2017/05/11 13:06:23 Yes, using those URLs will be fine as soon as we w
+ // only the url's origin is displayed instead.
alexmos 2017/05/10 22:33:08 This latter part doesn't apply to SourceLocation,
arthursonzogni 2017/05/11 13:06:23 source_location is used in console message and in
+ virtual bool IsOriginSafeToUseInCspViolation(const url::Origin& origin) const;
+
private:
bool has_self_ = false;
std::string self_scheme_;

Powered by Google App Engine
This is Rietveld 408576698