PlzNavigate: Do not disclose urls between cross-origin renderers.

content/common/content_security_policy/csp_context.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_CONTENT_SECURITY_POLICY_CSP_CONTEXT_H_
 #define CONTENT_COMMON_CONTENT_SECURITY_POLICY_CSP_CONTEXT_H_
 
 #include <vector>
 
 #include "content/common/content_export.h"
@@ skipping 37 matching lines @@
 
   bool SelfSchemeShouldBypassCsp();
 
   void ResetContentSecurityPolicies() { policies_.clear(); }
   void AddContentSecurityPolicy(const ContentSecurityPolicy& policy) {
     policies_.push_back(policy);
   }
 
   virtual bool SchemeShouldBypassCSP(const base::StringPiece& scheme);
 
+  // For security reasons, some urls must not be disclosed in console error
+  // messages, source location and reports. When this function returns false,

[alexmos, 2017/05/10 22:33:08]

Note: using those URLs in console error messages is fine/fixable, as long as
only the devtools process knows them, and we don't pass them through the
renderer process (see by comment on the disabled tests below).

[arthursonzogni, 2017/05/11 13:06:23]

Yes, using those URLs will be fine as soon as we will be able to send console
error message directly to the devtool process without using the renderer process
in between. I don't know how hard it is.

+  // only the url's origin is displayed instead.

[alexmos, 2017/05/10 22:33:08]

This latter part doesn't apply to SourceLocation, which you clear out entirely,
so perhaps the wording can account for that?  (I.e., it can clarify that it's
the blocked_url in violation events that is converted to origins.)

[arthursonzogni, 2017/05/11 13:06:23]

source_location is used in console message and in reports.
I need to fix this comment. It looks weird.

+  virtual bool IsOriginSafeToUseInCspViolation(const url::Origin& origin) const;
+
  private:
   bool has_self_ = false;
   std::string self_scheme_;
   CSPSource self_source_;
 
   std::vector<ContentSecurityPolicy> policies_;
 
   DISALLOW_COPY_AND_ASSIGN(CSPContext);
 };
 
@@ skipping 38 matching lines @@
 
   // Whether or not the violation happens after a redirect.
   bool after_redirect;
 
   // The source code location that triggered the blocked navigation.
   SourceLocation source_location;
 };
 
 }  // namespace content
 #endif  // CONTENT_COMMON_CONTENT_SECURITY_POLICY_CSP_CONTEXT_H_