Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 2869333002: Initialize test configuration to a default value. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index b0628dc839c5fd5e52c8b686dfdab5c84fbb5ce4..0d5e8525843bf5135e25fe09f9ae428ae57082ba 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -252,9 +252,11 @@ WebURL RewriteAbsolutePathInCsswgTest(const std::string& utf8_url) {
BlinkTestRunner::BlinkTestRunner(RenderView* render_view)
: RenderViewObserver(render_view),
RenderViewObserverTracker<BlinkTestRunner>(render_view),
+ test_config_(mojom::ShellTestConfiguration::New()),
is_main_window_(false),
focus_on_next_commit_(false),
leak_detector_(new LeakDetector(this)) {
+ test_config_->enable_pixel_dumping = true;
Sam McNally 2017/05/10 07:55:44 Why does this default to true?
Jia 2017/05/10 22:55:29 Because the old struct ShellTestConfiguration defa
Sam McNally 2017/05/10 23:37:13 In that case, maybe it makes sense to set that as
Jia 2017/05/11 00:42:02 Done. Thanks for pointing out!
}
BlinkTestRunner::~BlinkTestRunner() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698