Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869313003:
Delete Android joystick zoom code. (Closed)
|
Created:
3 years, 7 months ago by aelias_OOO_until_Jul13 Modified:
3 years, 7 months ago Reviewers:
boliu CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDelete Android joystick zoom code.
Reasons:
- This zooming code cannot naturally be refactored to use a similar approach as
http://crrev.com/472737; that would require introducing a "zoom velocity" to
fling events used only for this, which would be a maintenance burden.
- I tried connecting a PS4 controller and the trigger axes weren't mapped
at all. In general, button mapping on Android is highly random and the
left-stick is one of the only things mapped consistently. And this
wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway.
So it's unlikely that any users are benefiting from this feature except on
the specific controller-style NVidia Shield (which is a discontinued product)
that http://crrev.com/380572 was tested on.
- Zooming is a relatively obscure use case now that most sites are
mobile-optimized.
BUG=644488
Review-Url: https://codereview.chromium.org/2869313003
Cr-Commit-Position: refs/heads/master@{#473069}
Committed: https://chromium.googlesource.com/chromium/src/+/5c2987aea858fe28a76f6d41ca86ed2771b39e4b
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 28 (24 generated)
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Delete Android joystick zoom code. I tried connecting a PS4 controller to both a Nexus 6P running N, a Nexus 9 running M and a Nexus 7 2012 running K, and in all cases the left/right trigger buttons caused a switch of tabs left/right instead of zooming. So it seems that this zooming code runs against Android platform conventions and that the appropriate event stream to trigger it has probably only ever been generated on the NVidia Shield devices it was tested on originally (which are no longer being manufactured). This leaves stick-scrolling code, which does work on all devices, and which I plan to integrate with the CC fling system alongside other autoscrollers, instead of animating in Java. That approach doesn't naturally work with zooming, so this code would stick out as a particular maintenance burden after that. BUG=644488 ========== to ========== [WIP] Delete Android joystick zoom code. BUG=644488 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [WIP] Delete Android joystick zoom code. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which may be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mapping correction, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this except on the specific controller-style NVidia Shield (which is a discontinued product). - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ==========
Description was changed from ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which may be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mapping correction, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this except on the specific controller-style NVidia Shield (which is a discontinued product). - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mapping correction, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this except on the specific controller-style NVidia Shield (which is a discontinued product). - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ==========
Description was changed from ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mapping correction, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this except on the specific controller-style NVidia Shield (which is a discontinued product). - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product). - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ==========
Description was changed from ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product). - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested for. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ==========
Description was changed from ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested for. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested for. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ==========
Description was changed from ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the triggers weren't mapped correctly at all. In general, button mapping on Android is very poor and the left-stick is one of the only things mapped consistently at all. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested for. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the trigger axes weren't mapped at all. In general, button mapping on Android is highly random and the left-stick is one of the only things mapped consistently. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested for. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ==========
Description was changed from ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the trigger axes weren't mapped at all. In general, button mapping on Android is highly random and the left-stick is one of the only things mapped consistently. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested for. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the trigger axes weren't mapped at all. In general, button mapping on Android is highly random and the left-stick is one of the only things mapped consistently. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested on. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ==========
aelias@chromium.org changed reviewers: + boliu@chromium.org
Hi Bo, PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by aelias@chromium.org
The CQ bit was checked by aelias@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495162146918070,
"parent_rev": "5cf77c9e72082bfc4b0a7a9e1481b20569eacac5", "commit_rev":
"a402d6b0834d114213de919d10a40a1c0b789699"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495162146918070,
"parent_rev": "44116dd8f6d76d2b9c85d51e5916fe08604407a6", "commit_rev":
"5c2987aea858fe28a76f6d41ca86ed2771b39e4b"}
Message was sent while issue was closed.
Description was changed from ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the trigger axes weren't mapped at all. In general, button mapping on Android is highly random and the left-stick is one of the only things mapped consistently. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested on. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 ========== to ========== Delete Android joystick zoom code. Reasons: - This zooming code cannot naturally be refactored to use a similar approach as http://crrev.com/472737; that would require introducing a "zoom velocity" to fling events used only for this, which would be a maintenance burden. - I tried connecting a PS4 controller and the trigger axes weren't mapped at all. In general, button mapping on Android is highly random and the left-stick is one of the only things mapped consistently. And this wasn't hooked up to the gamepad mappings, which is wildly incomplete anyway. So it's unlikely that any users are benefiting from this feature except on the specific controller-style NVidia Shield (which is a discontinued product) that http://crrev.com/380572 was tested on. - Zooming is a relatively obscure use case now that most sites are mobile-optimized. BUG=644488 Review-Url: https://codereview.chromium.org/2869313003 Cr-Commit-Position: refs/heads/master@{#473069} Committed: https://chromium.googlesource.com/chromium/src/+/5c2987aea858fe28a76f6d41ca86... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5c2987aea858fe28a76f6d41ca86... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
