Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2869313002: Linux native notifications: Add const variables for DBus strings. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
Tom Anderson
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux native notifications: Add const variables for DBus strings. BUG=676220 Review-Url: https://codereview.chromium.org/2869313002 Cr-Commit-Position: refs/heads/master@{#470770} Committed: https://chromium.googlesource.com/chromium/src/+/4e5beb03dc2aed6e11e4ea8acf8ce8e77e10c08e

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, separate sections #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -25 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 1 2 9 chunks +55 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Lei Zhang
3 years, 7 months ago (2017-05-10 02:51:32 UTC) #2
Tom Anderson
lgtm https://codereview.chromium.org/2869313002/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2869313002/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode41 chrome/browser/notifications/notification_platform_bridge_linux.cc:41: // DBus names, paths, methods, and signals. nit: ...
3 years, 7 months ago (2017-05-10 06:11:48 UTC) #3
Lei Zhang
Will wait for your CLs to land first as they potentially conflict. https://codereview.chromium.org/2869313002/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc ...
3 years, 7 months ago (2017-05-10 21:11:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869313002/40001
3 years, 7 months ago (2017-05-11 00:05:07 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 01:23:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4e5beb03dc2aed6e11e4ea8acf8c...

Powered by Google App Engine
This is Rietveld 408576698