Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2869303004: Print Preview: Remove include from print_header.js (Closed)

Created:
3 years, 7 months ago by rbpotter
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Remove include from print_header.js BUG=717620 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2869303004 Cr-Commit-Position: refs/heads/master@{#471001} Committed: https://chromium.googlesource.com/chromium/src/+/066e8c280fe7db54e8dcc2ac4db464592ac6cd19

Patch Set 1 #

Patch Set 2 : Remove unnecessary dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/print_preview/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_header.js View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/webui/resources/js/cr/ui/compiled_resources2.gyp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
rbpotter
3 years, 7 months ago (2017-05-11 01:46:48 UTC) #7
dpapad
lgtm
3 years, 7 months ago (2017-05-11 02:11:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869303004/20001
3 years, 7 months ago (2017-05-11 16:41:30 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 17:38:32 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/066e8c280fe7db54e8dcc2ac4db4...

Powered by Google App Engine
This is Rietveld 408576698