Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2869283002: Remove the initial delay when first entering immersive fullscreen in a PWA. (Closed)

Created:
3 years, 7 months ago by dominickn
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the initial delay when first entering immersive fullscreen in a PWA. On first launch, PWAs open a splash screen. If the PWA is set to open in immersive fullscreen via the manifest property display: fullscreen, the splash screen currently opens in standalone non-immersive mode before the PWA transitions to immersive mode. At the point of transition, the splash screen icon "jumps" as the view resizes. This CL addresses this problem by transitioning immediately to immersive fullscreen before loading the splash screen. Now the splash screen opens directly into immersive fullscreen, removing any resizing. BUG=720174 Review-Url: https://codereview.chromium.org/2869283002 Cr-Commit-Position: refs/heads/master@{#470746} Committed: https://chromium.googlesource.com/chromium/src/+/d7631c332aae8ba4281325a4955e5a46e8b857f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dominickn
PTAL, thanks!
3 years, 7 months ago (2017-05-10 03:38:36 UTC) #6
Ted C
lgtm
3 years, 7 months ago (2017-05-10 14:42:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869283002/1
3 years, 7 months ago (2017-05-10 23:21:14 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 23:33:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7631c332aae8ba4281325a4955e...

Powered by Google App Engine
This is Rietveld 408576698