aura: Introduce EventInjector.

aura: Introduce EventInjector.

Introduce EventInjector, which can be used to inject events into aura.
In LOCAL mode, the events are directly injected on aura::WindowTreeHost.
In MUS mode, EventInjector injects the event at the window-server using
the WindowServerTest api.

BUG=721640
Review-Url: https://codereview.chromium.org/2869273010
Cr-Commit-Position: refs/heads/master@{#471806}
Committed: https://chromium.googlesource.com/chromium/src/+/8a7826ac6e0b8e4c18ca72ea7b03436185f199a5

[sadrul, 2017-05-12 03:19:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 03:20:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-05-12 03:50:46]

Description was changed from

==========
aura: Introduce EventInjector.

..

BUG=...
==========

to

==========
aura: Introduce EventInjector.

Introduce EventInjector, which can be used to inject events into aura.
In LOCAL mode, the events are directly injected on aura::WindowTreeHost.
In MUS mode, EventInjector injects the event at the window-server using
the WindowServerTest api.

BUG=721640
==========

[commit-bot: I haz the power, 2017-05-12 04:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 04:41:32]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-05-12 07:24:33]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-05-12 12:11:51]

https://codereview.chromium.org/2869273010/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
(right):

https://codereview.chromium.org/2869273010/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/synthetic_gesture_target_aura.cc:50:
aura::EventInjector injektor;
Is there a reason you went for injektor with a 'k' here rather than 'c'?

https://codereview.chromium.org/2869273010/diff/1/ui/aura/BUILD.gn
File ui/aura/BUILD.gn (right):

https://codereview.chromium.org/2869273010/diff/1/ui/aura/BUILD.gn#newcode65
ui/aura/BUILD.gn:65: "event_injector.cc",
Should EventInjector be test only? At least for mus you would need to make sure
you added the right capability, and we wouldn't want most clients using this
api.

https://codereview.chromium.org/2869273010/diff/1/ui/aura/event_injector.cc
File ui/aura/event_injector.cc (right):

https://codereview.chromium.org/2869273010/diff/1/ui/aura/event_injector.cc#n...
ui/aura/event_injector.cc:56: screen->GetPrimaryDisplay().id(),
MapEvent(*event),
Do we end up doing the right thing with multiple displays?

https://codereview.chromium.org/2869273010/diff/1/ui/aura/event_injector.h
File ui/aura/event_injector.h (right):

https://codereview.chromium.org/2869273010/diff/1/ui/aura/event_injector.h#ne...
ui/aura/event_injector.h:20: class AURA_EXPORT EventInjector {
Add description

[sadrul, 2017-05-12 21:12:40]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 21:13:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-05-12 21:26:09]

https://codereview.chromium.org/2869273010/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
(right):

https://codereview.chromium.org/2869273010/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/synthetic_gesture_target_aura.cc:50:
aura::EventInjector injektor;
On 2017/05/12 12:11:51, sky wrote:
> Is there a reason you went for injektor with a 'k' here rather than 'c'?

Whoops, sorry, no. Forgot to rename the variables during cleanup.

https://codereview.chromium.org/2869273010/diff/1/ui/aura/BUILD.gn
File ui/aura/BUILD.gn (right):

https://codereview.chromium.org/2869273010/diff/1/ui/aura/BUILD.gn#newcode65
ui/aura/BUILD.gn:65: "event_injector.cc",
On 2017/05/12 12:11:51, sky wrote:
> Should EventInjector be test only? At least for mus you would need to make
sure
> you added the right capability, and we wouldn't want most clients using this
> api.

It unfortunately can't be, right now, because telemetry tests run with normal
chrome binary. So yes, we need to add 'test' to the manifest too :-/ Not sure if
there's some way to add such capabilities at runtime instead of in the manifest.

https://codereview.chromium.org/2869273010/diff/1/ui/aura/event_injector.cc
File ui/aura/event_injector.cc (right):

https://codereview.chromium.org/2869273010/diff/1/ui/aura/event_injector.cc#n...
ui/aura/event_injector.cc:56: screen->GetPrimaryDisplay().id(),
MapEvent(*event),
On 2017/05/12 12:11:51, sky wrote:
> Do we end up doing the right thing with multiple displays?

Telemetry tests currently do not have tests for multi-displays (as far as I can
tell). But I have changed this code to use GetDisplayNearestWindow() instead.

[sky, 2017-05-12 21:50:25]

Sadrul and myself talked about this and he is going to sort of the
manifest/separate-binary separately. LGTM

[commit-bot: I haz the power, 2017-05-12 23:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:11:23]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sadrul, 2017-05-15 14:56:33]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:57:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 17:04:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494860193933900,
"parent_rev": "f4ab3233393c3c93a203bbd2ff21645c0f312107", "commit_rev":
"8a7826ac6e0b8e4c18ca72ea7b03436185f199a5"}

[commit-bot: I haz the power, 2017-05-15 17:04:57]

Description was changed from

==========
aura: Introduce EventInjector.

Introduce EventInjector, which can be used to inject events into aura.
In LOCAL mode, the events are directly injected on aura::WindowTreeHost.
In MUS mode, EventInjector injects the event at the window-server using
the WindowServerTest api.

BUG=721640
==========

to

==========
aura: Introduce EventInjector.

Introduce EventInjector, which can be used to inject events into aura.
In LOCAL mode, the events are directly injected on aura::WindowTreeHost.
In MUS mode, EventInjector injects the event at the window-server using
the WindowServerTest api.

BUG=721640

Review-Url: https://codereview.chromium.org/2869273010
Cr-Commit-Position: refs/heads/master@{#471806}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a7826ac6e0b8e4c18ca72ea7b03...
==========

[commit-bot: I haz the power, 2017-05-15 17:04:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a7826ac6e0b8e4c18ca72ea7b03...