Don't use KeyboardController::GetInstance() in KeyboardUI.

Don't use KeyboardController::GetInstance() in KeyboardUI.

Some tests doesn't set KeyboardController instance and it causes
test crashes when enabling "--use-new-virtual-keyboard-behavior" flag.
We can use keyboard_controller_ member instead.

BUG=624521
TEST=Covered by unit tests.

Review-Url: https://codereview.chromium.org/2869273007
Cr-Commit-Position: refs/heads/master@{#471240}
Committed: https://chromium.googlesource.com/chromium/src/+/f742bd099543025c6df1f7824a40b0f40f1e7cd3

[yhanada, 2017-05-11 07:14:22]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 07:15:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 08:16:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 08:16:55]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-05-11 08:18:22]

yhanada@chromium.org changed reviewers:
+ sadrul@chromium.org

[yhanada, 2017-05-11 08:18:23]

PTAL. Thanks!

[sadrul, 2017-05-11 17:25:06]

lgtm

https://codereview.chromium.org/2869273007/diff/1/ui/keyboard/keyboard_contro...
File ui/keyboard/keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/2869273007/diff/1/ui/keyboard/keyboard_contro...
ui/keyboard/keyboard_controller_unittest.cc:212: class KeyboardControllerTest :
public testing::TestWithParam<bool>,
Document what the param is for.

https://codereview.chromium.org/2869273007/diff/1/ui/keyboard/keyboard_contro...
ui/keyboard/keyboard_controller_unittest.cc:244: if
(!command_line->HasSwitch(::switches::kUseNewVirtualKeyboardBehavior))
Why do you need to check this?

[yhanada, 2017-05-12 04:53:54]

Thanks for your review.

https://codereview.chromium.org/2869273007/diff/1/ui/keyboard/keyboard_contro...
File ui/keyboard/keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/2869273007/diff/1/ui/keyboard/keyboard_contro...
ui/keyboard/keyboard_controller_unittest.cc:212: class KeyboardControllerTest :
public testing::TestWithParam<bool>,
On 2017/05/11 17:25:05, sadrul wrote:
> Document what the param is for.

Done.

https://codereview.chromium.org/2869273007/diff/1/ui/keyboard/keyboard_contro...
ui/keyboard/keyboard_controller_unittest.cc:244: if
(!command_line->HasSwitch(::switches::kUseNewVirtualKeyboardBehavior))
On 2017/05/11 17:25:05, sadrul wrote:
> Why do you need to check this?

Done.

[yhanada, 2017-05-12 04:54:00]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 04:54:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:58:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhanada, 2017-05-12 05:59:00]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-05-12 05:59:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2869273007/#ps20001
(title: "add the comment")

[commit-bot: I haz the power, 2017-05-12 05:59:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 07:00:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494568740521910,
"parent_rev": "39f50e39f87993743d1253c33dc5fe67caa5da05", "commit_rev":
"f742bd099543025c6df1f7824a40b0f40f1e7cd3"}

[commit-bot: I haz the power, 2017-05-12 07:00:38]

Description was changed from

==========
Don't use KeyboardController::GetInstance() in KeyboardUI.

Some tests doesn't set KeyboardController instance and it causes
test crashes when enabling "--use-new-virtual-keyboard-behavior" flag.
We can use keyboard_controller_ member instead.

BUG=624521
TEST=Covered by unit tests.
==========

to

==========
Don't use KeyboardController::GetInstance() in KeyboardUI.

Some tests doesn't set KeyboardController instance and it causes
test crashes when enabling "--use-new-virtual-keyboard-behavior" flag.
We can use keyboard_controller_ member instead.

BUG=624521
TEST=Covered by unit tests.

Review-Url: https://codereview.chromium.org/2869273007
Cr-Commit-Position: refs/heads/master@{#471240}
Committed:
https://chromium.googlesource.com/chromium/src/+/f742bd099543025c6df1f7824a40...
==========

[commit-bot: I haz the power, 2017-05-12 07:00:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f742bd099543025c6df1f7824a40...