Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2869273005: Revert of [chrome_elf] blacklist flaky tests (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
penny, robertshield
CC:
chromium-reviews, pennymac+watch_chromium.org, caitkp+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [chrome_elf] blacklist flaky tests (patchset #3 id:60001 of https://codereview.chromium.org/2861793003/ ) Reason for revert: This is still causing lots of flake. Original issue's description: > [chrome_elf] blacklist flaky tests > > Possible flake fix. Overriding chrome_elf test launch options. > > BUG=711651 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Review-Url: https://codereview.chromium.org/2861793003 > Cr-Commit-Position: refs/heads/master@{#470086} > Committed: https://chromium.googlesource.com/chromium/src/+/b1d09797bdb4b4b4340662a5bc25a0d611cc42ba TBR=robertshield@chromium.org,pennymac@chromium.org BUG=711651 NOTREECHECKS=true NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2869273005 Cr-Commit-Position: refs/heads/master@{#470670} Committed: https://chromium.googlesource.com/chromium/src/+/2435ed2540c29f9c76e0b35c96b72e0d531daa92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_elf/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
jam
Created Revert of [chrome_elf] blacklist flaky tests
3 years, 7 months ago (2017-05-10 19:33:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869273005/1
3 years, 7 months ago (2017-05-10 19:35:43 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 19:38:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2435ed2540c29f9c76e0b35c96b7...

Powered by Google App Engine
This is Rietveld 408576698